linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCHv2 3/3] Cleanup: Fix a compile error in hid-lg4ff and remove an extra include in hid-lg.h
@ 2012-03-14 17:41 Michal Malý
  0 siblings, 0 replies; 2+ messages in thread
From: Michal Malý @ 2012-03-14 17:41 UTC (permalink / raw)
  To: linux-input; +Cc: jkosina, simon

[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]

My mind was apparently wandering around a bit which lead to a compile error in hid-lg4ff.
I also forgot to remove the spinlock.h include from hid-lg.h I am sorry about this mess...

Signed-off-by: Michal Malý <madcatxster@gmail.com>

>From 61bbb9d5be1d8957ad8c6b63a4a6b911cb8aa12e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michal=20Mal=C3=BD?= <madcatxster@gmail.com>
Date: Wed, 14 Mar 2012 18:34:33 +0100
Subject: [PATCH 3/3] HID: hid-lg4ff: Fix hid_err call, hid-lg: Remove a
 superfluous include

---
 drivers/hid/hid-lg.h    |    2 --
 drivers/hid/hid-lg4ff.c |    2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/hid/hid-lg.h b/drivers/hid/hid-lg.h
index 500457b..d64cf8d 100644
--- a/drivers/hid/hid-lg.h
+++ b/drivers/hid/hid-lg.h
@@ -1,8 +1,6 @@
 #ifndef __HID_LG_H
 #define __HID_LG_H
 
-#include <linux/spinlock.h>
-
 struct lg_drv_data {
 	unsigned long quirks;
 	void *device_props;	/* Device specific properties */
diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
index f70ae41..1145292 100644
--- a/drivers/hid/hid-lg4ff.c
+++ b/drivers/hid/hid-lg4ff.c
@@ -481,7 +481,7 @@ int lg4ff_deinit(struct hid_device *hid)
 	}
 
 	if (!found) {
-		dbg_err("Device entry not found!\n");
+		hid_err(hid, "Device entry not found!\n");
 		return -1;
 	}
 
-- 
1.7.9.4



[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCHv2 3/3] Cleanup: Fix a compile error in hid-lg4ff and remove an extra include in hid-lg.h
@ 2012-03-14 17:41 Michal Malý
  0 siblings, 0 replies; 2+ messages in thread
From: Michal Malý @ 2012-03-14 17:41 UTC (permalink / raw)
  To: linux-input; +Cc: jkosina, simon

[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]

My mind was apparently wandering around a bit which lead to a compile error in 
hid-lg4ff.
I also forgot to remove the spinlock.h include from hid-lg.h I am sorry about 
this mess...

Signed-off-by: Michal Malý <madcatxster@gmail.com>

>From 61bbb9d5be1d8957ad8c6b63a4a6b911cb8aa12e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michal=20Mal=C3=BD?= <madcatxster@gmail.com>
Date: Wed, 14 Mar 2012 18:34:33 +0100
Subject: [PATCH 3/3] HID: hid-lg4ff: Fix hid_err call, hid-lg: Remove a
 superfluous include

---
 drivers/hid/hid-lg.h    |    2 --
 drivers/hid/hid-lg4ff.c |    2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/hid/hid-lg.h b/drivers/hid/hid-lg.h
index 500457b..d64cf8d 100644
--- a/drivers/hid/hid-lg.h
+++ b/drivers/hid/hid-lg.h
@@ -1,8 +1,6 @@
 #ifndef __HID_LG_H
 #define __HID_LG_H
 
-#include <linux/spinlock.h>
-
 struct lg_drv_data {
 	unsigned long quirks;
 	void *device_props;	/* Device specific properties */
diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
index f70ae41..1145292 100644
--- a/drivers/hid/hid-lg4ff.c
+++ b/drivers/hid/hid-lg4ff.c
@@ -481,7 +481,7 @@ int lg4ff_deinit(struct hid_device *hid)
 	}
 
 	if (!found) {
-		dbg_err("Device entry not found!\n");
+		hid_err(hid, "Device entry not found!\n");
 		return -1;
 	}
 
-- 
1.7.9.4


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-03-14 18:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-14 17:41 [PATCHv2 3/3] Cleanup: Fix a compile error in hid-lg4ff and remove an extra include in hid-lg.h Michal Malý
  -- strict thread matches above, loose matches on Subject: below --
2012-03-14 17:41 Michal Malý

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).