From: Jingoo Han <jg1.han@samsung.com>
To: "fugang.duan@freescale.com" <fugang.duan@freescale.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Benson Leung <bleung@chromium.org>,
Daniel Kurtz <djkurtz@chromium.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
Jingoo Han <jg1.han@samsung.com>
Subject: Re: [patch] Input: remove a duplicative NULL test
Date: Sun, 23 Feb 2014 23:23:42 +0000 (GMT) [thread overview]
Message-ID: <22951681.102711393197819005.JavaMail.weblogic@epml01> (raw)
On Friday, February 21, 2014 6:15 PM, fugang.duan@freescale.com wrote:
>
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Data: Friday, February 21, 2014 4:55 PM
>
> >To: Dmitry Torokhov
> >Cc: Paul Gortmaker; Jingoo Han; Duan Fugang-B38611; Benson Leung; Daniel Kurtz;
> >linux-input@vger.kernel.org; kernel-janitors@vger.kernel.org
> >Subject: [patch] Input: remove a duplicative NULL test
> >
> >"pdata" is non-NULL here. We verified that at the start of the function.
> >
> >Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> >diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c
> >b/drivers/input/touchscreen/atmel_mxt_ts.c
> >index a70400754e92..40abe90cc924 100644
> >--- a/drivers/input/touchscreen/atmel_mxt_ts.c
> >+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
> >@@ -1146,7 +1146,7 @@ static int mxt_probe(struct i2c_client *client,
> > goto err_free_mem;
> > }
> >
> >- data->is_tp = pdata && pdata->is_tp;
> >+ data->is_tp = pdata->is_tp;
> >
> > input_dev->name = (data->is_tp) ? "Atmel maXTouch Touchpad" :
> > "Atmel maXTouch Touchscreen";
> >
> Agree, it is redundant. And if you have free time, you can convert the driver to support devicetree.
>
> Acked-by: Fugang Duan <B38611@freescale.com>
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
next reply other threads:[~2014-02-23 23:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-23 23:23 Jingoo Han [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-02-21 8:55 [patch] Input: remove a duplicative NULL test Dan Carpenter
2014-02-21 9:14 ` fugang.duan
2014-03-13 4:24 ` Benson Leung
2014-03-19 16:02 ` Nick Dyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22951681.102711393197819005.JavaMail.weblogic@epml01 \
--to=jg1.han@samsung.com \
--cc=bleung@chromium.org \
--cc=dan.carpenter@oracle.com \
--cc=djkurtz@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fugang.duan@freescale.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).