linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>,
	linux-input@vger.kernel.org,
	Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH 2/6] v4l2-subdev: add start/end messages for log_status.
Date: Tue, 07 Feb 2012 11:49:06 +0100	[thread overview]
Message-ID: <2337556.GQrkDqkaKo@avalon> (raw)
In-Reply-To: <5dc424690702cb423288fe9b1e30f7ad225fc6e5.1328183271.git.hans.verkuil@cisco.com>

Hi Hans,

Thanks for the patch.

On Thursday 02 February 2012 12:56:32 Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
> 
> Add the start and end messages for log_status when called from a
> subdev device node.
> 
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/video/v4l2-subdev.c |   12 ++++++++++--
>  1 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/video/v4l2-subdev.c
> b/drivers/media/video/v4l2-subdev.c index 41d118e..6fe88e9 100644
> --- a/drivers/media/video/v4l2-subdev.c
> +++ b/drivers/media/video/v4l2-subdev.c
> @@ -194,8 +194,16 @@ static long subdev_do_ioctl(struct file *file, unsigned
> int cmd, void *arg) }
>  #endif
> 
> -	case VIDIOC_LOG_STATUS:
> -		return v4l2_subdev_call(sd, core, log_status);
> +	case VIDIOC_LOG_STATUS: {
> +		int ret;
> +
> +		pr_info("%s: =================  START STATUS  =================\n",
> +			sd->name);
> +		ret = v4l2_subdev_call(sd, core, log_status);
> +		pr_info("%s: ==================  END STATUS  ==================\n",
> +			sd->name);
> +		return ret;
> +	}
> 
>  #if defined(CONFIG_VIDEO_V4L2_SUBDEV_API)
>  	case VIDIOC_SUBDEV_G_FMT: {

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2012-02-07 10:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-02 11:56 [PATCH 0/6] Add support functions and the radio-keene driver Hans Verkuil
2012-02-02 11:56 ` [PATCH 1/6] v4l2: standardize log start/end message Hans Verkuil
2012-02-02 11:56   ` [PATCH 2/6] v4l2-subdev: add start/end messages for log_status Hans Verkuil
2012-02-07 10:49     ` Laurent Pinchart [this message]
2012-02-02 11:56   ` [PATCH 3/6] v4l2-ctrls: add helper functions for control events Hans Verkuil
2012-02-02 11:56   ` [PATCH 4/6] vivi: use v4l2_ctrl_subscribe_event Hans Verkuil
2012-02-02 11:56   ` [PATCH 5/6] radio-keene: add a driver for the Keene FM Transmitter Hans Verkuil
2012-02-02 11:56   ` [PATCH 6/6] hid-core: ignore the Keene FM transmitter Hans Verkuil
2012-02-02 12:02     ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2337556.GQrkDqkaKo@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=hans.verkuil@cisco.com \
    --cc=hverkuil@xs4all.nl \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).