Linux Input/HID development
 help / color / mirror / Atom feed
From: Olivier Goffart <olivier@woboq.com>
To: Tai-hwa Liang <avatar@sentelic.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Fix sentelic multi-touch driver
Date: Fri, 29 Jun 2012 17:00:39 +0200	[thread overview]
Message-ID: <2421405.kgV4JOQPin@gargamel> (raw)
In-Reply-To: <12062922475617.19930@cnaqrzbavhz.fragryvp.pbz>

On Friday 29 June 2012 22:51:16 Tai-hwa Liang wrote:
> On Fri, 29 Jun 2012, Olivier Goffart wrote:
> > On Friday 29 June 2012 11:03:12 Tai-hwa Liang wrote:
> [...]
> 
> >>    With the correct flag(FSP_BIT_SWC1_EN_GID) being set, the hardware
> >> 
> >> clears MFMC bit during 2 -> 1 finger transition.  The attached patch is
> >> an aggregated version against Dmitry's master branch, which supposes to
> >> fix
> >> the testing case listed above.
> > 
> > I am testing against the stable 3.4.y branch.
> > With that patch, scrolling is very slow, and it emits middle click
> > sometimes while I want to scroll fast.
> > 
> > Looking at the debug output, i see a lot of NOTIFY packets, for the same
> > number of packets/seconds (77). So then there is 5 times less multi touch
> > events. Maybe that's why.
> 
>    I see. It appears to me that we'd better to revert back to the
> last_mt_fgr workaround to avoid such delay.

That last patch seems to work perfectly.

Thanks
-- 
Olivier

  reply	other threads:[~2012-06-29 15:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-27 20:36 [PATCH] Fix sentelic multi-touch driver Olivier Goffart
2012-06-28  8:02 ` Tai-hwa Liang
2012-06-28  8:25   ` Olivier Goffart
2012-06-28  9:17     ` Tai-hwa Liang
2012-06-28  9:44       ` Olivier Goffart
2012-06-29  3:03         ` Tai-hwa Liang
2012-06-29  7:52           ` Olivier Goffart
2012-06-29 14:51             ` Tai-hwa Liang
2012-06-29 15:00               ` Olivier Goffart [this message]
2012-07-11  8:50                 ` Olivier Goffart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2421405.kgV4JOQPin@gargamel \
    --to=olivier@woboq.com \
    --cc=avatar@sentelic.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox