linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michal Malý" <madcatxster@devoid-pointer.net>
To: dmitry.torokhov@gmail.com, jkosina@suse.cz
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Elias Vanderstuyft <elias.vds@gmail.com>
Subject: [PATCH 02/24] Port arizona-haptics to ff-memless-next
Date: Wed, 09 Apr 2014 13:14:22 +0200	[thread overview]
Message-ID: <2461623.gOt8QLnnPs@sigyn> (raw)
In-Reply-To: <1609685.QRL9N9sQvX@sigyn>

Port arizona-haptics to ff-memless-next

Signed-off-by: Michal Malý <madcatxster@devoid-pointer.net>
---
 drivers/input/misc/Kconfig           |  2 +-
 drivers/input/misc/arizona-haptics.c | 39 +++++++++++++++++++++++-------------
 2 files changed, 26 insertions(+), 15 deletions(-)

diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index 7904ab0..33e0f5d 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -75,7 +75,7 @@ config INPUT_AD714X_SPI
 config INPUT_ARIZONA_HAPTICS
 	tristate "Arizona haptics support"
 	depends on MFD_ARIZONA && SND_SOC
-	select INPUT_FF_MEMLESS
+	select INPUT_FF_MEMLESS_NEXT
 	help
 	  Say Y to enable support for the haptics module in Arizona CODECs.
 
diff --git a/drivers/input/misc/arizona-haptics.c b/drivers/input/misc/arizona-haptics.c
index ef2e281..b4707cc 100644
--- a/drivers/input/misc/arizona-haptics.c
+++ b/drivers/input/misc/arizona-haptics.c
@@ -13,6 +13,7 @@
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/input.h>
+#include <linux/input/ff-memless-next.h>
 #include <linux/slab.h>
 
 #include <sound/soc.h>
@@ -22,6 +23,8 @@
 #include <linux/mfd/arizona/pdata.h>
 #include <linux/mfd/arizona/registers.h>
 
+#define FF_UPDATE_RATE 50
+
 struct arizona_haptics {
 	struct arizona *arizona;
 	struct input_dev *input_dev;
@@ -108,29 +111,37 @@ static void arizona_haptics_work(struct work_struct *work)
 }
 
 static int arizona_haptics_play(struct input_dev *input, void *data,
-				struct ff_effect *effect)
+				const struct mlnx_effect_command *command)
 {
 	struct arizona_haptics *haptics = input_get_drvdata(input);
 	struct arizona *arizona = haptics->arizona;
+	const struct mlnx_rumble_force *rumble_force = &command->u.rumble_force;
 
 	if (!arizona->dapm) {
 		dev_err(arizona->dev, "No DAPM context\n");
 		return -EBUSY;
 	}
 
-	if (effect->u.rumble.strong_magnitude) {
-		/* Scale the magnitude into the range the device supports */
-		if (arizona->pdata.hap_act) {
-			haptics->intensity =
-				effect->u.rumble.strong_magnitude >> 9;
-			if (effect->direction < 0x8000)
-				haptics->intensity += 0x7f;
+	switch (command->cmd) {
+	case MLNX_START_RUMBLE:
+		if (rumble_force->strong) {
+			/* Scale the magnitude into the range the device supports */
+			if (arizona->pdata.hap_act) {
+				haptics->intensity = rumble_force->strong >> 9;
+				if (rumble_force->strong_dir < 0x8000)
+					haptics->intensity += 0x7f;
+			} else {
+				haptics->intensity = rumble_force->strong >> 8;
+			}
 		} else {
-			haptics->intensity =
-				effect->u.rumble.strong_magnitude >> 8;
+			haptics->intensity = 0;
 		}
-	} else {
+		break;
+	case MLNX_STOP_RUMBLE:
 		haptics->intensity = 0;
+		break;
+	default:
+		return -EINVAL;
 	}
 
 	schedule_work(&haptics->work);
@@ -183,10 +194,10 @@ static int arizona_haptics_probe(struct platform_device *pdev)
 	haptics->input_dev->close = arizona_haptics_close;
 	__set_bit(FF_RUMBLE, haptics->input_dev->ffbit);
 
-	ret = input_ff_create_memless(haptics->input_dev, NULL,
-				      arizona_haptics_play);
+	ret = input_ff_create_mlnx(haptics->input_dev, NULL,
+				   arizona_haptics_play, FF_UPDATE_RATE);
 	if (ret < 0) {
-		dev_err(arizona->dev, "input_ff_create_memless() failed: %d\n",
+		dev_err(arizona->dev, "input_ff_create_mlnx() failed: %d\n",
 			ret);
 		goto err_ialloc;
 	}
-- 
1.9.1

  parent reply	other threads:[~2014-04-09 11:14 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09 11:10 [PATCH 0/24] Introduce ff-memless-next as an improved replacement for ff-memless Michal Malý
2014-04-09 11:13 ` [PATCH 01/24] Add ff-memless-next module Michal Malý
2014-04-09 11:14 ` Michal Malý [this message]
2014-04-09 11:15 ` [PATCH 03/24] Port twl4030-vibra to ff-memless-next Michal Malý
2014-04-09 11:16 ` [PATCH 04/24] Port twl6040-vibra " Michal Malý
2014-04-09 11:17 ` [PATCH 05/24] Port max8997_haptic " Michal Malý
2014-04-09 11:17 ` [PATCH 06/24] Port pm8xxx-vibrator " Michal Malý
2014-04-09 11:18 ` [PATCH 07/24] Port hid-axff " Michal Malý
2014-04-09 11:19 ` [PATCH 08/24] Port hid-emsff " Michal Malý
2014-04-09 11:21 ` [PATCH 09/24] Port hid-dr " Michal Malý
2014-04-09 11:22 ` [PATCH 10/24] Port hid-gaff " Michal Malý
2014-04-09 11:23 ` [PATCH 11/24] Port hid-holtekff " Michal Malý
2014-04-09 11:24 ` [PATCH 12/24] Port hid-lgff " Michal Malý
2014-04-20 22:00   ` Elias Vanderstuyft
2014-04-09 11:24 ` [PATCH 13/24] Port hid-lg3ff " Michal Malý
2014-04-20 22:13   ` Elias Vanderstuyft
2014-04-09 11:25 ` [PATCH 14/24] Port hid-pl " Michal Malý
2014-04-09 11:26 ` [PATCH 15/24] Port hid-sjoy " Michal Malý
2014-04-09 11:27 ` [PATCH 16/24] Port hid-sony " Michal Malý
2014-04-09 11:28 ` [PATCH 17/24] Port hid-tmff " Michal Malý
2014-04-09 11:28 ` [PATCH 18/24] Port hid-wiimote-modules " Michal Malý
2014-04-09 11:29 ` [PATCH 19/24] Port hid-zpff " Michal Malý
2014-04-09 11:30 ` [PATCH 20/24] Port gamecon " Michal Malý
2014-04-09 11:31 ` [PATCH 21/24] Port xpad " Michal Malý
2014-04-09 11:33 ` [PATCH 22/24] Port hid-lg2ff " Michal Malý
2014-04-09 11:35 ` [PATCH 23/24] Port hid-lg4ff " Michal Malý
2014-04-20 17:27   ` simon
2014-04-09 11:36 ` [PATCH 24/24] Replace ff-memless with ff-memless-next Michal Malý
2014-04-20 17:27 ` [PATCH 0/24] Introduce ff-memless-next as an improved replacement for ff-memless simon
2014-04-20 22:05   ` Elias Vanderstuyft
2014-04-20 22:29     ` simon
2014-04-21 11:25       ` Elias Vanderstuyft
  -- strict thread matches above, loose matches on Subject: below --
2014-04-22 13:45 [PATCH v2 00/24] input: " Michal Malý
2014-04-22 13:45 ` [PATCH 02/24] Port arizona-haptics to ff-memless-next Michal Malý

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2461623.gOt8QLnnPs@sigyn \
    --to=madcatxster@devoid-pointer.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=elias.vds@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).