linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Filipe Laíns" <lains@archlinux.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming
Date: Sat, 30 Jan 2021 20:40:52 +0000	[thread overview]
Message-ID: <25a6c40cd26158b74c9a58dc53a2f0905a2ea1d8.camel@archlinux.org> (raw)
In-Reply-To: <0a3aa6fb-3f22-d6f5-1748-42430f6e7ccc@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 718 bytes --]

On Sat, 2021-01-30 at 21:27 +0100, Hans de Goede wrote:
> Hi,
> 
> On 1/30/21 8:14 PM, Filipe Laíns wrote:
> > Hans,
> > 
> > You added support for non unifying receivers in
> > 74808f9115cee2bb53e7161432959f3e87b631e4, could you please test and make
> > sure
> > this cause any breakage with your devices?
> > 
> > AFAIK, they could only break if they have a 0x01 report which is different
> > from
> > kbd_descriptor.
> 
> I don't have any receivers hitting the "case 7" which you are modifying,
> so I don't expect to see any effects of this change on my hw.
> 
> Regards,
> 
> Hans
> 

Alright, then we should not have any other receivers that use this protocol.

Cheers,
Filipe Laíns

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-01-30 20:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-30 19:10 [PATCH] HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming Filipe Laíns
2021-01-30 19:14 ` Filipe Laíns
2021-01-30 19:29   ` Filipe Laíns
2021-01-30 20:27   ` Hans de Goede
2021-01-30 20:40     ` Filipe Laíns [this message]
2021-02-05  9:18 ` Jiri Kosina
2021-02-05 14:36   ` Filipe Laíns

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25a6c40cd26158b74c9a58dc53a2f0905a2ea1d8.camel@archlinux.org \
    --to=lains@archlinux.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=hdegoede@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).