From: Hans de Goede <hdegoede@redhat.com>
To: Dmitry Mastykin <dmastykin@astralinux.ru>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Bastien Nocera <hadess@hadess.net>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 2/2] Input: goodix - Ignore spurious interrupts
Date: Tue, 10 Mar 2020 15:55:36 +0100 [thread overview]
Message-ID: <25d0a14b-359f-c032-79bd-8fcaad8c650d@redhat.com> (raw)
In-Reply-To: <20200310131705.13516-2-dmastykin@astralinux.ru>
Hi,
On 3/10/20 2:17 PM, Dmitry Mastykin wrote:
This patch completely lacks a "body" for the commit message,
please write a paragraph about why you are making this change
here.
Regards,
Hans
> Signed-off-by: Dmitry Mastykin <dmastykin@astralinux.ru>
> ---
> drivers/input/touchscreen/goodix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
> index 6a7ecc6..7f8ad6d 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -329,7 +329,7 @@ static int goodix_ts_read_input_report(struct goodix_ts_data *ts, u8 *data)
> * The Goodix panel will send spurious interrupts after a
> * 'finger up' event, which will always cause a timeout.
> */
> - return 0;
> + return -ENOMSG;
> }
>
> static void goodix_ts_report_touch_8b(struct goodix_ts_data *ts, u8 *coor_data)
>
next prev parent reply other threads:[~2020-03-10 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 13:17 [PATCH 1/2] Input: goodix - Add support for touch-keys and keycode mapping Dmitry Mastykin
2020-03-10 13:17 ` [PATCH 2/2] Input: goodix - Ignore spurious interrupts Dmitry Mastykin
2020-03-10 14:55 ` Hans de Goede [this message]
2020-03-10 14:40 ` [PATCH 1/2] Input: goodix - Add support for touch-keys and keycode mapping Hans de Goede
2020-03-10 15:29 ` Dmitry Mastykin
2020-03-10 15:37 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25d0a14b-359f-c032-79bd-8fcaad8c650d@redhat.com \
--to=hdegoede@redhat.com \
--cc=dmastykin@astralinux.ru \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).