From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v2 0/3] input: Dynamic Minor Numbers Date: Fri, 21 Sep 2012 13:51:30 -0700 Message-ID: <2737921.JXTsrgJ0N6@dtor-d630.eng.vmware.com> References: <1348163523-2062-1-git-send-email-dh.herrmann@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:56194 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932170Ab2IUUvf (ORCPT ); Fri, 21 Sep 2012 16:51:35 -0400 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: David Herrmann Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Friday, September 21, 2012 09:18:00 PM David Herrmann wrote: > Hi Dmitry > > On Fri, Sep 21, 2012 at 11:22 AM, David Herrmann > > wrote: > > Hi Dmitry > > > > On Fri, Sep 21, 2012 at 10:07 AM, Dmitry Torokhov > > > > wrote: > >> Thank you very much for working on this, unfortunately your patch extends > >> the existing infrastructure handling of character devices in input core, > >> which is quite rigid and sub-optimal. > >> > >> For a while now I wanted to stop input core from pre-creating character > >> devices and multiplexing file operations and instead push more chardev > >> handling tasks into individual input handlers and make they more > >> independent from input core. So while I won't be taking your patch as is > >> it was a great motivator to finally do something about current > >> limitation and I would appreciate if you could take a look at the patch > >> below and see if you have any issues with it. > > > > I didn't know why we did that, anyway. But I tried to keep that logic, > > even though it is really weird. So I am quite glad that you fixed it. > > Sorry, compiling a kernel takes 44m here so I haven't had time earlier > this day. But I just recompiled with your patch and it works like a > charm. I have attached output of "ls -la /dev/input" with 900 uinput > devices. Performance does suck but that is definitely another issue. Could you elaborate a bit on this? > > So here's my: > Tested-by: David Herrmann Thanks for testing! -- Dmitry