From: "Arnd Bergmann" <arnd@arndb.de>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Cc: "kernel test robot" <lkp@intel.com>,
"Raag Jadav" <raag.jadav@intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
lgirdwood@gmail.com, "Mark Brown" <broonie@kernel.org>,
"Sebastian Reichel" <sre@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"Przemek Kitszel" <przemyslaw.kitszel@intel.com>,
oe-kbuild-all@lists.linux.dev,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-sound@vger.kernel.org, linux-pm@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v4 01/20] driver core: Split devres APIs to device/devres.h
Date: Tue, 11 Feb 2025 11:23:07 +0100 [thread overview]
Message-ID: <279d9f32-a1c9-41aa-b15a-e1485877b2d5@app.fastmail.com> (raw)
In-Reply-To: <Z6siYlWfvfUvNLpX@smile.fi.intel.com>
On Tue, Feb 11, 2025, at 11:11, Andy Shevchenko wrote:
> On Tue, Feb 11, 2025 at 10:39:16AM +0100, Arnd Bergmann wrote:
>> On Tue, Feb 11, 2025, at 10:27, Andy Shevchenko wrote:
>
>> I don't mind moving that if it helps you, but don't see what
>> the problem is here. Is this missing because of a circular
>> #include list with linux/device.h including asm/io.h and vice
>> versa? If that is the root cause, then I assume there will be
>> additional problems either way until the loop can be broken.
>
> I don't see how. io.h already includes err.h, so whoever includes io.h should
> have that as previously.
I mean I never understood what problem you are trying to solve
exactly. From the log, it appears that the problem is an include
loop between linux/device.h, linux/device/devres.h and asm/io.h,
and anything that breaks the loop should work. Your suggestion of
stopping asm/io.h from including linux/device.h sounds like
the most promising here, but this should be possible regardless
of whether IOMEM_ERR_PTR() gets moved.
Arnd
next prev parent reply other threads:[~2025-02-11 10:23 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 6:48 [PATCH v4 00/20] Split devres APIs to device/devres.h and introduce devm_kmemdup_array() Raag Jadav
2025-02-10 6:48 ` [PATCH v4 01/20] driver core: Split devres APIs to device/devres.h Raag Jadav
2025-02-10 14:08 ` kernel test robot
2025-02-10 14:30 ` kernel test robot
2025-02-10 15:23 ` Andy Shevchenko
2025-02-10 21:35 ` Raag Jadav
2025-02-11 7:36 ` Arnd Bergmann
2025-02-11 9:27 ` Andy Shevchenko
2025-02-11 9:39 ` Arnd Bergmann
2025-02-11 10:11 ` Andy Shevchenko
2025-02-11 10:23 ` Arnd Bergmann [this message]
2025-02-11 11:37 ` Andy Shevchenko
2025-02-11 11:56 ` Arnd Bergmann
2025-02-11 12:10 ` Andy Shevchenko
2025-02-11 12:57 ` Raag Jadav
2025-02-10 18:43 ` kernel test robot
2025-02-10 6:48 ` [PATCH v4 02/20] iio: imu: st_lsm9ds0: Replace device.h with what is needed Raag Jadav
2025-02-10 6:48 ` [PATCH v4 03/20] devres: Introduce devm_kmemdup_array() Raag Jadav
2025-02-10 6:48 ` [PATCH v4 04/20] pinctrl: intel: copy communities using devm_kmemdup_array() Raag Jadav
2025-02-10 6:48 ` [PATCH v4 05/20] pinctrl: baytrail: " Raag Jadav
2025-02-10 6:48 ` [PATCH v4 06/20] pinctrl: cherryview: use devm_kmemdup_array() Raag Jadav
2025-02-10 6:48 ` [PATCH v4 07/20] pinctrl: tangier: " Raag Jadav
2025-02-10 6:48 ` [PATCH v4 08/20] pinctrl: pxa2xx: " Raag Jadav
2025-02-10 6:48 ` [PATCH v4 09/20] input: sparse-keymap: " Raag Jadav
2025-02-10 6:48 ` [PATCH v4 10/20] input: ipaq-micro-keys: " Raag Jadav
2025-02-10 6:48 ` [PATCH v4 11/20] regulator: devres: " Raag Jadav
2025-02-10 6:48 ` [PATCH v4 12/20] regulator: cros-ec: " Raag Jadav
2025-02-10 6:48 ` [PATCH v4 13/20] power: supply: sc27xx: " Raag Jadav
2025-02-10 6:49 ` [PATCH v4 14/20] iio: adc: xilinx-xadc-core: " Raag Jadav
2025-02-10 6:49 ` [PATCH v4 15/20] ASoC: Intel: avs: " Raag Jadav
2025-02-10 6:49 ` [PATCH v4 16/20] ASoC: hdac_hdmi: " Raag Jadav
2025-02-10 6:49 ` [PATCH v4 17/20] ASoC: tlv320dac33: " Raag Jadav
2025-02-10 6:49 ` [PATCH v4 18/20] ASoC: uda1380: " Raag Jadav
2025-02-10 6:49 ` [PATCH v4 19/20] ASoC: meson: axg-tdm-interface: " Raag Jadav
2025-02-10 6:49 ` [PATCH v4 20/20] ASoC: uniphier: " Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=279d9f32-a1c9-41aa-b15a-e1485877b2d5@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=przemyslaw.kitszel@intel.com \
--cc=raag.jadav@intel.com \
--cc=rafael@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).