linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Aleksei Mamlin <mamlinav@gmail.com>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] input: goodix: Add bindings documentation
Date: Mon, 19 Jan 2015 13:13:03 +0100	[thread overview]
Message-ID: <2837065.M1EAkbKi5o@wuerfel> (raw)
In-Reply-To: <1421505410-9537-1-git-send-email-mamlinav@gmail.com>

On Saturday 17 January 2015 17:36:50 Aleksei Mamlin wrote:
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/gt9xx.txt
> @@ -0,0 +1,23 @@
> +Device tree bindings for Goodix GT9xx series touchscreen controller
> +
> +Required properties:
> +
> + - compatible          : Should be "goodix,gt9xx"
> + - reg                 : I2C address of the chip
> + - interrupt-parent    : Interrupt controller to which the chip is connected
> + - interrupts          : Interrupt to which the chip is connected
> +
> 

You should avoid the use of wildcards in compatible strings. Better list
all the known part numbers, or (if they are 100% compatible with one another)
pick the oldest one we support and use that as the compatible string.

	Arnd

  reply	other threads:[~2015-01-19 12:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-17 14:34 [PATCH 0/3] Add device tree support for Goodix GT9xx series touchscreen controller Aleksei Mamlin
     [not found] ` <1421505253-7474-1-git-send-email-mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-17 14:36   ` [PATCH 1/3] input: goodix: Add device tree support Aleksei Mamlin
     [not found]     ` <1421505361-8871-1-git-send-email-mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-17 20:38       ` Bastien Nocera
     [not found]         ` <1421527085.2075.12.camel-0MeiytkfxGOsTnJN9+BGXg@public.gmane.org>
2015-01-18 12:25           ` Алексей Мамлин
2015-01-18 14:22             ` Antonio Ospite
2015-01-18 15:12               ` Aleksei Mamlin
2015-01-17 14:36 ` [PATCH 2/3] dt-bindings: Add vendor-prefix for Goodix Aleksei Mamlin
2015-01-17 14:36 ` [PATCH 3/3] input: goodix: Add bindings documentation Aleksei Mamlin
2015-01-19 12:13   ` Arnd Bergmann [this message]
2015-01-17 20:37 ` [PATCH 0/3] Add device tree support for Goodix GT9xx series touchscreen controller Bastien Nocera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2837065.M1EAkbKi5o@wuerfel \
    --to=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=mamlinav@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).