From: "Brüns, Stefan" <Stefan.Bruens@rwth-aachen.de>
To: Bastien Nocera <hadess@hadess.net>
Cc: "platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/5] Input: add KEY_ROTATE_LOCK_TOGGLE
Date: Thu, 30 Nov 2017 17:51:37 +0000 [thread overview]
Message-ID: <2845999.tyV6EiPLrg@sbruens-linux> (raw)
In-Reply-To: <1510270493.2624.49.camel@hadess.net>
On Freitag, 10. November 2017 00:34:53 CET Bastien Nocera wrote:
> On Thu, 2017-11-09 at 23:44 +0100, Stefan Brüns wrote:
> > The key has the same use as the SW_ROTATE_LOCK, but is used on
> > devices
> > where the state is not tracked by the hardware but has to be handled
> > in software.
>
> I'll let the input and hid subsystem maintainers have the final say
> here, though I think that sending out Win+O would be easier, as this is
> already something that desktops need to support for those devices that
> send the actual Win+O key combination when those buttons are pressed
> there.
>
> If we're going with the separate keycode, could you also file bugs
> against xkbd-common and xkeyboard-config to get the key added to the
> list of XF86 keysyms and to the default evdev keymap? Otherwise Wayland
> and X11 based desktops won't be able to use it.
Filed for xkeyboard-config:
https://bugs.freedesktop.org/show_bug.cgi?id=103998
and xkb-common:
https://github.com/xkbcommon/libxkbcommon/issues/55
Regards,
Stefan
next prev parent reply other threads:[~2017-11-30 17:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171109224436.16472-1-stefan.bruens@rwth-aachen.de>
2017-11-09 22:44 ` [PATCH v2 1/5] platform/x86: intel-vbtn: support SW_TABLET_MODE Stefan Brüns
2017-11-09 22:44 ` [PATCH v2 2/5] platform/x86: intel-vbtn: Support separate press/release events Stefan Brüns
2017-11-10 1:34 ` Darren Hart
2017-11-10 1:58 ` Stefan Brüns
2017-11-10 2:11 ` Darren Hart
2017-11-10 2:44 ` Stefan Brüns
2017-11-10 2:15 ` Darren Hart
2017-12-08 20:33 ` Stefan Brüns
2017-11-09 22:44 ` [PATCH v2 3/5] Input: add KEY_ROTATE_LOCK_TOGGLE Stefan Brüns
2017-11-09 23:34 ` Bastien Nocera
2017-11-30 17:51 ` Brüns, Stefan [this message]
2017-12-05 18:50 ` Jason Gerecke
2018-01-25 16:23 ` Jason Gerecke
2017-11-10 1:41 ` Darren Hart
2017-11-09 22:44 ` [PATCH v2 4/5] platform/x86: intel-vbtn: support KEY_ROTATE_LOCK_TOGGLE Stefan Brüns
2017-11-09 23:30 ` Bastien Nocera
2017-11-09 23:46 ` Darren Hart
2017-11-10 0:23 ` Stefan Brüns
2017-11-10 0:15 ` Stefan Brüns
2017-11-10 0:39 ` Bastien Nocera
2017-11-10 0:53 ` Darren Hart
2017-11-10 1:54 ` Darren Hart
2017-11-10 2:20 ` Stefan Brüns
2017-11-09 22:44 ` [PATCH v2 5/5] platform/x86: intel-vbtn: support panel front button Stefan Brüns
2017-11-09 23:40 ` Bastien Nocera
2017-11-10 0:21 ` Stefan Brüns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2845999.tyV6EiPLrg@sbruens-linux \
--to=stefan.bruens@rwth-aachen.de \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).