From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
"Mario Limonciello (AMD) (kernel.org)" <superm1@kernel.org>
Cc: usama.anjum@collabora.com, Len Brown <lenb@kernel.org>,
Pavel Machek <pavel@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Danilo Krummrich <dakr@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-input@vger.kernel.org,
kernel@collabora.com
Subject: Re: [RFC 1/4] PM: hibernate: export hibernation_in_progress()
Date: Wed, 22 Oct 2025 21:27:21 +0500 [thread overview]
Message-ID: <288e4d9c-a3e4-4f7e-a68c-330704e5125d@collabora.com> (raw)
In-Reply-To: <CAJZ5v0hCxpWXdnoQeW79kaDFmHcfE0A4k7JuA9T+RR1OyCw29w@mail.gmail.com>
On 10/22/25 2:53 PM, Rafael J. Wysocki wrote:
> On Tue, Oct 21, 2025 at 11:07 PM Mario Limonciello (AMD) (kernel.org)
> <superm1@kernel.org> wrote:
>>
>>
>>
>> On 10/18/2025 9:21 AM, Muhammad Usama Anjum wrote:
>>> Export hibernation_in_progress() to be used by other modules. Add its
>>> signature when hibernation config isn't enabled as well.
>>
>> I wonder if you actually want to have pm_sleep_transition_in_progress()
>> exported instead. "Logically" I would expect cancelling a hibernate and
>> cancelling a suspend should work similarly.
>
> Well, it does AFAICS, except that only the "freeze" and "poweroff"
> transitions can be aborted during hibernation. This is analogous to
> aborting a suspend transition.
I'll switch up with pm_sleep_transition_in_progress().
>
> The missing part is a mechanism to cancel hibernation between image
> creation and the "poweroff" transition.
I'll add wakeup checking there and see if it works.
--
---
Thanks,
Usama
next prev parent reply other threads:[~2025-10-22 16:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-18 14:21 [RFC 0/4] PM: Hibernate: Add hibernation cancellation support Muhammad Usama Anjum
2025-10-18 14:21 ` [RFC 1/4] PM: hibernate: export hibernation_in_progress() Muhammad Usama Anjum
2025-10-21 21:07 ` Mario Limonciello (AMD) (kernel.org)
2025-10-22 9:53 ` Rafael J. Wysocki
2025-10-22 16:27 ` Muhammad Usama Anjum [this message]
2025-10-18 14:21 ` [RFC 2/4] ACPI: button: Cancel hibernation if button is pressed during hibernation Muhammad Usama Anjum
2025-10-21 21:12 ` Mario Limonciello (AMD) (kernel.org)
2025-10-18 14:21 ` [RFC 3/4] Input: Ignore the KEY_POWER events if hibernation is in progress Muhammad Usama Anjum
2025-10-21 21:14 ` Mario Limonciello (AMD) (kernel.org)
2025-10-22 16:33 ` Muhammad Usama Anjum
2025-10-22 16:40 ` Mario Limonciello
2025-10-18 14:21 ` [RFC 4/4] PM: sleep: clear pm_abort_suspend at suspend Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=288e4d9c-a3e4-4f7e-a68c-330704e5125d@collabora.com \
--to=usama.anjum@collabora.com \
--cc=dakr@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@collabora.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=superm1@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).