From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Yue Haibing <yuehaibing@huawei.com>,
jikos@kernel.org, benjamin.tissoires@redhat.com
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH -next] HID: intel-ish-hid: Remove unused declarations
Date: Mon, 28 Aug 2023 03:53:16 -0700 [thread overview]
Message-ID: <2907aeaaa7ec5b1a04b08c1dd3ec236c88787a16.camel@linux.intel.com> (raw)
In-Reply-To: <20230817135053.51964-1-yuehaibing@huawei.com>
On Thu, 2023-08-17 at 21:50 +0800, Yue Haibing wrote:
> Commit 3703f53b99e4 ("HID: intel_ish-hid: ISH Transport layer")
> declared ishtp_remove_all_clients()/ishtp_can_client_connect()
> but never implemented them.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Sorry I was on vacation to ACK before.
> ---
> drivers/hid/intel-ish-hid/ishtp/bus.h | 1 -
> drivers/hid/intel-ish-hid/ishtp/client.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.h
> b/drivers/hid/intel-ish-hid/ishtp/bus.h
> index 5bb85c932e4c..53645ac89ee8 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/bus.h
> +++ b/drivers/hid/intel-ish-hid/ishtp/bus.h
> @@ -46,7 +46,6 @@ struct ishtp_cl_device {
> };
>
> int ishtp_bus_new_client(struct ishtp_device *dev);
> -void ishtp_remove_all_clients(struct ishtp_device *dev);
> int ishtp_cl_device_bind(struct ishtp_cl *cl);
> void ishtp_cl_bus_rx_event(struct ishtp_cl_device *device);
>
> diff --git a/drivers/hid/intel-ish-hid/ishtp/client.h
> b/drivers/hid/intel-ish-hid/ishtp/client.h
> index fc62dd1495da..d9d398fadcf7 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/client.h
> +++ b/drivers/hid/intel-ish-hid/ishtp/client.h
> @@ -109,7 +109,6 @@ struct ishtp_cl {
> };
>
> /* Client connection managenment internal functions */
> -int ishtp_can_client_connect(struct ishtp_device *ishtp_dev, guid_t
> *uuid);
> int ishtp_fw_cl_by_id(struct ishtp_device *dev, uint8_t client_id);
> void ishtp_cl_send_msg(struct ishtp_device *dev, struct ishtp_cl
> *cl);
> void recv_ishtp_cl_msg(struct ishtp_device *dev,
prev parent reply other threads:[~2023-08-28 10:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 13:50 [PATCH -next] HID: intel-ish-hid: Remove unused declarations Yue Haibing
2023-08-28 10:53 ` srinivas pandruvada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2907aeaaa7ec5b1a04b08c1dd3ec236c88787a16.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox