Re: [PATCH v3 1/2] input: Add new driver for ARM CLPS711X keypad

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Monday, March 31, 2014 12:19:35 AM Alexander Shiyan wrote:
> Fri, 28 Mar 2014 09:42:28 -0700 от Dmitry Torokhov 
<dmitry.torokhov@gmail.com>:
> > Hi Alexander,
> > 
> > On Tue, Mar 18, 2014 at 10:02:19PM +0400, Alexander Shiyan wrote:
> > > +	err = input_register_polled_device(poll_dev);
> > > +	if (!err) {
> > > +		/* Report initial state */
> > > +		clps711x_keypad_poll(poll_dev);
> > > +
> > > +		return 0;
> > > +	}
> > 
> > The polled device core will report initial state when input device is
> > opened (as long as polling is enabled) so I removed this cunk and
> > applied the rest.
> 
> I looked amended version, it is made incorrectly.
> ...
> + err = input_register_polled_device(poll_dev);
> + if (err)
> + goto out_err;
> +
> +out_err:
> + input_free_polled_device(poll_dev);
> ...
> 
> Should be:
>  err = input_register_polled_device(poll_dev);
>  if (!err)
>  return 0;

Yes, I missed that "return 0;" should be fixed now.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html