From: Bastien Nocera <hadess@hadess.net>
To: Nate Yocom <nate@yocom.org>, dmitry.torokhov@gmail.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] Input: joystick: xpad: Add X-Box Adaptive Controller XBox button
Date: Wed, 17 Aug 2022 12:37:34 +0200 [thread overview]
Message-ID: <2a521e4f327778e390f344da16c9df0b6dea82fb.camel@hadess.net> (raw)
In-Reply-To: <20220813185343.2306-4-nate@yocom.org>
On Sat, 2022-08-13 at 11:53 -0700, Nate Yocom wrote:
> Adaptive controller sets 0x02 bit for this button, all others set
> 0x01
> so presence of either is used for BTN_MODE.
>
> Signed-off-by: Nate Yocom <nate@yocom.org>
Tested-by: Bastien Nocera <hadess@hadess.net>
> ---
> drivers/input/joystick/xpad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/joystick/xpad.c
> b/drivers/input/joystick/xpad.c
> index 83a4f4d07af5..bea71721b6cd 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -859,7 +859,7 @@ static void xpadone_process_packet(struct
> usb_xpad *xpad, u16 cmd, unsigned char
> if (data[1] == 0x30)
> xpadone_ack_mode_report(xpad, data[2]);
>
> - input_report_key(dev, BTN_MODE, data[4] & 0x01);
> + input_report_key(dev, BTN_MODE, data[4] & 0x03);
> input_sync(dev);
> return;
> }
prev parent reply other threads:[~2022-08-17 10:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-13 18:53 [PATCH v3 0/3] Input: joystick: xpad: Add X-Box Adaptive Controller support Nate Yocom
2022-08-13 18:53 ` [PATCH v3 1/3] " Nate Yocom
2022-08-17 10:37 ` Bastien Nocera
2022-08-17 17:36 ` Nate Yocom
2022-08-13 18:53 ` [PATCH v3 2/3] Input: joystick: xpad: Add X-Box Adaptive Controller Layer button Nate Yocom
2022-08-17 10:37 ` Bastien Nocera
2022-08-17 17:42 ` Nate Yocom
2022-08-24 15:36 ` Bastien Nocera
2022-08-25 22:21 ` Nate Yocom
2022-08-13 18:53 ` [PATCH v3 3/3] Input: joystick: xpad: Add X-Box Adaptive Controller XBox button Nate Yocom
2022-08-17 10:37 ` Bastien Nocera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a521e4f327778e390f344da16c9df0b6dea82fb.camel@hadess.net \
--to=hadess@hadess.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nate@yocom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).