From: Vicki Pfau <vi@endrift.com>
To: Dan Carpenter <error27@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Dongliang Mu <dzm91@hust.edu.cn>, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: xpad - Move Xbox 360 magic packet sending
Date: Fri, 28 Apr 2023 16:15:01 -0700 [thread overview]
Message-ID: <2be8ff85-57d3-fd80-adcd-a7dc50c2e27d@endrift.com> (raw)
In-Reply-To: <facb01dd-e704-4900-8f4c-6d6972e75176@kili.mountain>
Hi Dmitry,
On 4/18/23 21:28, Dan Carpenter wrote:
> On Tue, Apr 18, 2023 at 07:24:14PM -0700, Vicki Pfau wrote:
>> This moves the sending of the magic packet introduced in db7220c48d8d from
>> xpad_probe to xpad_start_input to ensure that xpad->dev->dev exists in the
>> event that an error occurs. This should also fix issues with suspend that may
>> occur with some controllers.
>>
>> Fixes: db7220c48d8d ("Input: xpad - fix support for some third-party controllers")
>> Signed-off-by: Vicki Pfau <vi@endrift.com>
>
> Can you add the syzbot stuff as well and a Reported-by tag for
> Dongliang Mu as well.
>
> Reported-by: syzbot+a3f758b8d8cb7e49afec@syzkaller.appspotmail.com
> Reported-by: Dongliang Mu <dzm91@hust.edu.cn>
> Link: https://groups.google.com/g/syzkaller-bugs/c/iMhTgpGuIbM
Do I need to add these to the commit myself and resend, or, barring code revisions, can this be added when you cherry-pick into the tree?
>
> regards,
> dan carpenter
>
Vicki
next prev parent reply other threads:[~2023-04-28 23:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 2:24 [PATCH] Input: xpad - Move Xbox 360 magic packet sending Vicki Pfau
2023-04-19 4:28 ` Dan Carpenter
2023-04-28 23:15 ` Vicki Pfau [this message]
2023-05-01 22:11 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2be8ff85-57d3-fd80-adcd-a7dc50c2e27d@endrift.com \
--to=vi@endrift.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dzm91@hust.edu.cn \
--cc=error27@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).