From: Dave Hansen <dave.hansen@intel.com>
To: Jiri Kosina <jkosina@suse.cz>,
Hans de Goede <hdegoede@redhat.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: hid-related 5.2-rc1 boot hang
Date: Tue, 28 May 2019 09:43:59 -0700 [thread overview]
Message-ID: <2c1684f6-9def-93dc-54ab-888142fd5e71@intel.com> (raw)
I have a system that works fine on 5.1. When updating to 5.2-rc1, it
hangs at boot waiting on an instance of systemd-udevd. The kernel
backtrace (https://photos.app.goo.gl/EV8rf7FofWouvdeE8) looks like it's
doing an finit_module() that dives into the hid code and is waiting on a
request_module().
This hang only occurs if I have a particular USB device inserted:
> Bus 001 Device 007: ID 046d:c52b Logitech, Inc. Unifying Receiver
Bisecting the issue points at this (unlikely to be the culprit) commit:
> [161f62cd07fde123fd52bf6d5b6fd6513cca968e] HID: macally: Add support for Macally ikey keyboard
This bisect result is probably just a bisect artifact. The first real,
bad commit is a merge commit: 63b6f0b827d. This commit merges a bunch
of stuff, but includes changes to the hid request_module() code and to
the logitech-hidpp which is the driver for the above device.
I also have a picture of the hang which includes __request_module()
dumping out the string it is passed:
https://photos.app.goo.gl/tUETiCBZHJfKqWPu8
This is easy enough to work around, and the system works fine if I just
unplug the Logitech device and plug it in after boot. But, it would be
nice to figure out what's going wrong. I guess it could easily be some
interaction between systemd, the driver and the request_module() ordering.
next reply other threads:[~2019-05-28 16:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 16:43 Dave Hansen [this message]
2019-05-28 17:14 ` hid-related 5.2-rc1 boot hang Jiri Kosina
2019-05-28 17:45 ` Benjamin Tissoires
2019-05-28 18:11 ` Dave Hansen
2019-05-29 9:17 ` Hans de Goede
2019-05-30 16:56 ` Dave Hansen
2019-05-31 22:15 ` Jiri Kosina
2019-06-03 9:11 ` Hans de Goede
2019-06-03 9:32 ` Hans de Goede
2019-06-03 9:51 ` Hans de Goede
2019-06-03 13:55 ` Benjamin Tissoires
2019-06-03 14:17 ` Hans de Goede
2019-06-04 7:51 ` Benjamin Tissoires
2019-06-04 8:05 ` Hans de Goede
2019-06-04 8:36 ` Hans de Goede
2019-06-04 8:53 ` Benjamin Tissoires
2019-06-04 21:08 ` Jiri Kosina
2019-06-05 12:29 ` Benjamin Tissoires
2019-06-04 10:08 ` Benjamin Tissoires
2019-06-04 10:50 ` Hans de Goede
2019-06-04 12:25 ` Benjamin Tissoires
2019-06-04 13:12 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c1684f6-9def-93dc-54ab-888142fd5e71@intel.com \
--to=dave.hansen@intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).