From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D052EC433B4 for ; Wed, 19 May 2021 16:13:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AEFA06135A for ; Wed, 19 May 2021 16:13:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241485AbhESQO4 (ORCPT ); Wed, 19 May 2021 12:14:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:28879 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241741AbhESQOv (ORCPT ); Wed, 19 May 2021 12:14:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621440811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ym7f63hOuYGl6Fks8S3xfcXYeM6JuCHnQnE/LmDsC+w=; b=S+FvZ5yY8ilIDEder/qbd2tmesFup+rO9shqZ+Rm5qDj5yKQ7ySWEfrjlPOznXyDQ9UOxV uxUbdSyABwzr8fQ7rkDNpFbd8shWhITm3L/b60HA0IE3ea/1ZcJMVoXCwVqleBsHcDqDke c2b0CiYye+37gMWydmlFso7QKrfXP78= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-320-xhcM9zbdOCiS_skDc8ZLGA-1; Wed, 19 May 2021 12:13:27 -0400 X-MC-Unique: xhcM9zbdOCiS_skDc8ZLGA-1 Received: by mail-ej1-f70.google.com with SMTP id p25-20020a1709061419b0290378364a6464so3894068ejc.15 for ; Wed, 19 May 2021 09:13:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ym7f63hOuYGl6Fks8S3xfcXYeM6JuCHnQnE/LmDsC+w=; b=pq0Kq1y1Dp5aKkBGmtKXWZ69NXFVnADd+04wPnzeL0WFAXbqa12UkBAbvvXm5Yp7ks eSxU7nN7PCdawsJW+Xyj4FIf739xbg8TQzT6PifaHVWHkOc7JWkFP+bST3ZFYG0BRLRm 7SUymQgKE84Bt/7vW5Y+HE3nYa2DrvD0tR7YZj71T6j02m1OkeWw36c59Xj+KDL4Y7+L lNkeFjE17mg3MBcZSnqegR/BFq/vi/kXIPpFV57IUmq4+NDW4LT9LWlMY+jV5BrcmxLz U/WM/4LUYTki7Lh4dS/58+pdvMzxc/ToHmFgAaFQhnqg6XHURjiSkNAA3iS36VpfSqBu LylQ== X-Gm-Message-State: AOAM531q0dWJr3B2DotAi4YNGiGaXy21mDgdFZ3Kn+M7Uwjf+Za2TKab 2wvsQiKn/NjEJK12hOIA78RmsGL2+MLyyJB5SnjS2A+AXyEX0Ur1kthI6oPeHcDai60+ohyoGFk PCGa7Dwu+dMwdWycBDk3pmXU= X-Received: by 2002:a05:6402:2298:: with SMTP id cw24mr15527112edb.156.1621440806273; Wed, 19 May 2021 09:13:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnTN24eRl34SNmfx7WHavN7lqQcZzDt7hRHYCP7UdJMNzIybsDyWB05IdjzXMOktdqUwQ20w== X-Received: by 2002:a05:6402:2298:: with SMTP id cw24mr15527099edb.156.1621440806116; Wed, 19 May 2021 09:13:26 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id gz8sm72730ejb.38.2021.05.19.09.13.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 May 2021 09:13:25 -0700 (PDT) Subject: Re: [PATCH] HID: input: Add support for Programmable Buttons To: =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= , linux-input@vger.kernel.org, Jiri Kosina , Benjamin Tissoires Cc: =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= , linux-kernel@vger.kernel.org References: <61dcf8c7-2dcb-4173-fbbd-9adf3412edb7@redhat.com> <20210519160349.609690-1-linux@weissschuh.net> From: Hans de Goede Message-ID: <2dc197eb-a222-8af6-f0ab-f722e4f492ca@redhat.com> Date: Wed, 19 May 2021 18:13:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210519160349.609690-1-linux@weissschuh.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi, On 5/19/21 6:03 PM, Thomas Weißschuh wrote: > From: Thomas Weißschuh > > Map them to KEY_MACRO# event codes. > > These buttons are defined by HID as follows: > "The user defines the function of these buttons to control software > applications or GUI objects." > > This matches the semantics of the KEY_MACRO# input event codes that > Linux supports. > > Signed-off-by: Thomas Weißschuh > --- > drivers/hid/hid-debug.c | 11 +++++++++++ > drivers/hid/hid-input.c | 1 + > 2 files changed, 12 insertions(+) > > diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c > index 59f8d716d78f..0e76d9b4530a 100644 > --- a/drivers/hid/hid-debug.c > +++ b/drivers/hid/hid-debug.c > @@ -122,6 +122,7 @@ static const struct hid_usage_entry hid_usage_table[] = { > { 9, 0, "Button" }, > { 10, 0, "Ordinal" }, > { 12, 0, "Consumer" }, > + {0, 0x003, "ProgrammableButtons"}, > {0, 0x238, "HorizontalWheel"}, > { 13, 0, "Digitizers" }, > {0, 0x01, "Digitizer"}, > @@ -939,6 +940,16 @@ static const char *keys[KEY_MAX + 1] = { > [KEY_KBDINPUTASSIST_NEXTGROUP] = "KbdInputAssistNextGroup", > [KEY_KBDINPUTASSIST_ACCEPT] = "KbdInputAssistAccept", > [KEY_KBDINPUTASSIST_CANCEL] = "KbdInputAssistCancel", > + [KEY_MACRO1] = "Macro1", [KEY_MACRO2] = "Macro2", [KEY_MACRO3] = "Macro3", > + [KEY_MACRO4] = "Macro4", [KEY_MACRO5] = "Macro5", [KEY_MACRO6] = "Macro6", > + [KEY_MACRO7] = "Macro7", [KEY_MACRO8] = "Macro8", [KEY_MACRO9] = "Macro9", > + [KEY_MACRO10] = "Macro10", [KEY_MACRO11] = "Macro11", [KEY_MACRO12] = "Macro12", > + [KEY_MACRO13] = "Macro13", [KEY_MACRO14] = "Macro14", [KEY_MACRO15] = "Macro15", > + [KEY_MACRO16] = "Macro16", [KEY_MACRO17] = "Macro17", [KEY_MACRO18] = "Macro18", > + [KEY_MACRO19] = "Macro19", [KEY_MACRO20] = "Macro20", [KEY_MACRO21] = "Macro21", > + [KEY_MACRO22] = "Macro22", [KEY_MACRO23] = "Macro23", [KEY_MACRO24] = "Macro24", > + [KEY_MACRO25] = "Macro25", [KEY_MACRO26] = "Macro26", [KEY_MACRO27] = "Macro27", > + [KEY_MACRO28] = "Macro28", [KEY_MACRO29] = "Macro29", [KEY_MACRO30] = "Macro30", > }; > > static const char *relatives[REL_MAX + 1] = { > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c > index 18f5e28d475c..7d4dee58d869 100644 > --- a/drivers/hid/hid-input.c > +++ b/drivers/hid/hid-input.c > @@ -632,6 +632,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel > else > code += BTN_TRIGGER_HAPPY - 0x10; > break; > + case HID_CP_CONSUMER_CONTROL: code += KEY_MACRO1; break; Shouldn't there be a check here to ensure that we don't map things above KEY_MACRO30 ? if we do that then we start hitting other codes like KEY_MACRO_RECORD_START and eventually BTN_TRIGGER_HAPPY and after the BTN_TRIGGER_HAPPY range we go over KEY_MAX which I think is not supported ? Regards, Hans > default: > switch (field->physical) { > case HID_GD_MOUSE: > > base-commit: efd8929b9eec1cde120abb36d76dd00ff6711023 >