From: Werner Sembach <wse@tuxedocomputers.com>
To: Benjamin Tissoires <bentiss@kernel.org>
Cc: Jiri Kosina <jikos@kernel.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hid/hid-multitouch: Keep latency normal on deactivate for reactivation gesture
Date: Thu, 6 Nov 2025 19:19:00 +0100 [thread overview]
Message-ID: <2f418bd7-b1fe-442b-983b-6308cf32fe57@tuxedocomputers.com> (raw)
In-Reply-To: <s2pc7whgvrwaldkgkle4ydkyc26q75senkmtesv57du6x7bxoa@mq3ght3dksdr>
Am 06.11.25 um 17:50 schrieb Benjamin Tissoires:
> On Nov 06 2025, Werner Sembach wrote:
>> Uniwill devices have a built in gesture in the touchpad to de- and
>> reactivate it by double taping the upper left corner. This gesture stops
>> working when latency is set to high, so this patch keeps the latency on
>> normal.
>>
>> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
>> ---
>> Or should I better implement this as a quirk?
> Yeah, I guess a quirk would be appreciated. The high latency on close
> was introduced on purpose for saving energy purpose. So this patch is
> rather not nice for those systems where it matters.
ack
v2 incoming
>
> Cheers,
> Benjamin
>
>> drivers/hid/hid-multitouch.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
>> index 179dc316b4b51..df64cb6c41699 100644
>> --- a/drivers/hid/hid-multitouch.c
>> +++ b/drivers/hid/hid-multitouch.c
>> @@ -1998,7 +1998,7 @@ static void mt_on_hid_hw_open(struct hid_device *hdev)
>>
>> static void mt_on_hid_hw_close(struct hid_device *hdev)
>> {
>> - mt_set_modes(hdev, HID_LATENCY_HIGH, TOUCHPAD_REPORT_NONE);
>> + mt_set_modes(hdev, HID_LATENCY_NORMAL, TOUCHPAD_REPORT_NONE);
>> }
>>
>> /*
>> --
>> 2.43.0
>>
prev parent reply other threads:[~2025-11-06 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 15:45 [PATCH] hid/hid-multitouch: Keep latency normal on deactivate for reactivation gesture Werner Sembach
2025-11-06 15:48 ` Werner Sembach
2025-11-06 16:50 ` Benjamin Tissoires
2025-11-06 18:19 ` Werner Sembach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f418bd7-b1fe-442b-983b-6308cf32fe57@tuxedocomputers.com \
--to=wse@tuxedocomputers.com \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).