linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lyude Paul <lyude@redhat.com>
To: K900 <me@0upti.me>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Gaurav Agrawal <agrawalgaurav@gnome.org>,
	Yussuf Khalil <dev@pp3345.net>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Dennis Kadioglu <denk@eclipso.email>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Joe Perches <joe@perches.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input/synaptics: enable InterTouch for ThinkPad X1E 1st gen
Date: Mon, 06 Jul 2020 13:22:35 -0400	[thread overview]
Message-ID: <2f68590f3352c6384efdf9838f16837d5990d1fe.camel@redhat.com> (raw)
In-Reply-To: <20200703143457.132373-1-me@0upti.me>

FWIW it's not placebo, it's why I always immediately notice when starting up a
new ThinkPad sample from lenovo if RMI4 is enabled or not :).

Anyway thank you for the patch, assuming you double-checked that clicking with
the clickpad still works (I made this mistake last time when trying to enable
this for the second generation X1 extreme):

Reviewed-by: Lyude Paul <lyude@redhat.com>

On Fri, 2020-07-03 at 17:34 +0300, K900 wrote:
> From: Ilya Katsnelson <me@0upti.me>
> 
> Tested on my own laptop, touchpad feels slightly more responsive with
> this on, though it might just be placebo.
> 
> Signed-off-by: Ilya Katsnelson <me@0upti.me>
> ---
>  drivers/input/mouse/synaptics.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 758dae8d6500..4b81b2d0fe06 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -179,6 +179,7 @@ static const char * const smbus_pnp_ids[] = {
>  	"LEN0093", /* T480 */
>  	"LEN0096", /* X280 */
>  	"LEN0097", /* X280 -> ALPS trackpoint */
> +	"LEN0099", /* X1 Extreme 1st */
>  	"LEN009b", /* T580 */
>  	"LEN200f", /* T450s */
>  	"LEN2044", /* L470  */


  reply	other threads:[~2020-07-06 17:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-03 14:34 [PATCH] input/synaptics: enable InterTouch for ThinkPad X1E 1st gen K900
2020-07-06 17:22 ` Lyude Paul [this message]
2020-07-06 19:20   ` Ilya K
2020-07-07  1:13 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f68590f3352c6384efdf9838f16837d5990d1fe.camel@redhat.com \
    --to=lyude@redhat.com \
    --cc=agrawalgaurav@gnome.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=denk@eclipso.email \
    --cc=dev@pp3345.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=joe@perches.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@0upti.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).