From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 135CE1BFE17 for ; Thu, 10 Oct 2024 09:13:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728551601; cv=none; b=A+tlffzV/n5PmA+u3uefI9T7rucSXDvgzgGC7fNsXTs8ZD9bj5u20ECRxvvgWOE7QFgrKduWnfyIvCf8R2xLospZYLXTV/n/X5EgcCodVFB+fcjlfE9alhkAZoYtX5fMn++vdJfKTHXyTkD0nQGEMwpTHvGxLT+WgZSKvV+Fqpg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728551601; c=relaxed/simple; bh=v4XN18e+CyZcuqWrnUyls/e8CpJTrCIwM8PKMvwb8/g=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=MDhaqf5YDGhY3oOSAU1G38/6iYMSNqqaJvlPZw1A1/lTHz0zIsxgDeV9piotI4LQab6Gpm+RO/x/4iKgWHkyd8WgDRMnxTXfYVrCd1dXmiK9fLvvfUu39aLRBTGXD1rXWigS1wHJsQGRPS+xvxVhG+3jZ4bn3Zz1XvBJ1zZn1Xs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Q76N3HfN; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q76N3HfN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728551599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v4XN18e+CyZcuqWrnUyls/e8CpJTrCIwM8PKMvwb8/g=; b=Q76N3HfNqza4POZgD7K7OrONoA26XNpc5StIxS5XaazIXGoOmNxjutMvwtNJ190BGmG27i IjdlKlEyCCgGd6bMskGZ0hdhOJ/GGpgdkANc3ZJG2Rk6h3r9xhYXAuGGB7YRhwseAE6Imw LphWC1GiQMQ68QJs3NQlSxKaqZ6+GEc= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-w91uEMx3ODKrNaWc2cqdLA-1; Thu, 10 Oct 2024 05:13:18 -0400 X-MC-Unique: w91uEMx3ODKrNaWc2cqdLA-1 Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-71e123d3d22so862162b3a.3 for ; Thu, 10 Oct 2024 02:13:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728551595; x=1729156395; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=v4XN18e+CyZcuqWrnUyls/e8CpJTrCIwM8PKMvwb8/g=; b=sVJQHcosFQXUCW3/BQT7WAjcXuVtT0icU3EbaJ9e6kY8FeL0uWuQelOepSuscbQDA8 Y9i+u3694ZjL9em+iXNH7tC4EpeorTbplh65d8LFiwLvnlODVD/LOWPQzw1LqVL/VuK9 +SFAVeCG6X/q0R+Snv2fK/ky96k/qQMBGNMVsArhxc0OLD6nZETNsFD/2Uh2DWxmiGyw UZZnOBJ1jbRsOh+T/Jbq00Z1qblnDBMUyTAV3MIfnKFSg1hX2vvN9U3lw9X8/56iXYN7 bOUwxtwC4n2LdDBhw47n9y4BITEzEsJzY+SXP4eNvAPBfzDj9vWMj8lmcToRMFqmQaDI JpYw== X-Forwarded-Encrypted: i=1; AJvYcCVXZJQVa7spZoY/EDntpdTQ6F0jLc4z1RTFJUpiwtOT6Qe468XvHW9jL1XcKKtQ1xe38fJ/PkpjEN7fPA==@vger.kernel.org X-Gm-Message-State: AOJu0YxPoAbEpnXTYmqQZX49lvYkQxfENRP5RNwl6YaK6jnltBEkttRR dl91zhaq9gyHifSQ+RMVJZEgoTwxJRYioC5mtK4VjgKQb3lIulgskZlYuv0sBXJLpi54QPaiKXk I1ncTxu+8jZ0jq51P/6DW8Hod5Yd7s9oWJboFLlUlzbyAr4rERfM0AMe/AiG9 X-Received: by 2002:a05:6a00:3e12:b0:71e:cc7:c511 with SMTP id d2e1a72fcca58-71e1dbc7610mr9332043b3a.23.1728551594968; Thu, 10 Oct 2024 02:13:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGep+sT+xfvdEWHCwKXB/cVXFvEo8d4o8Uec70ymXyXBB7IFwxFmp57q9aFEQPPEpGRMx5+Ug== X-Received: by 2002:a05:6a00:3e12:b0:71e:cc7:c511 with SMTP id d2e1a72fcca58-71e1dbc7610mr9331963b3a.23.1728551594451; Thu, 10 Oct 2024 02:13:14 -0700 (PDT) Received: from dhcp-64-16.muc.redhat.com (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e2ab0a617sm642626b3a.192.2024.10.10.02.12.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2024 02:13:14 -0700 (PDT) Message-ID: <306f4f0c8c966647170cf7fdab11285dba976ea1.camel@redhat.com> Subject: Re: [RFC PATCH 10/13] staging: rts5280: Use always-managed version of pci_intx() From: Philipp Stanner To: Greg Kroah-Hartman Cc: Philipp Hortmann , Damien Le Moal , Niklas Cassel , Sergey Shtylyov , Basavaraj Natikar , Jiri Kosina , Benjamin Tissoires , Arnd Bergmann , Alex Dubov , Sudarsana Kalluru , Manish Chopra , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Igor Mitsyanko , Sergey Matyukevich , Kalle Valo , Sanjay R Mehta , Shyam Sundar S K , Jon Mason , Dave Jiang , Allen Hubbe , Bjorn Helgaas , Alex Williamson , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jaroslav Kysela , Takashi Iwai , Mario Limonciello , Chen Ni , Ricky Wu , Al Viro , Breno Leitao , Kevin Tian , Thomas Gleixner , Ilpo =?ISO-8859-1?Q?J=E4rvinen?= , Mostafa Saleh , Andy Shevchenko , Hannes Reinecke , John Garry , Soumya Negi , Jason Gunthorpe , Yi Liu , "Dr. David Alan Gilbert" , Christian Brauner , Ankit Agrawal , Reinette Chatre , Eric Auger , Ye Bin , Marek =?ISO-8859-1?Q?Marczykowski-G=F3recki?= , Pierre-Louis Bossart , Maarten Lankhorst , Kai Vehmanen , Peter Ujfalusi , Rui Salvaterra , Marc Zyngier , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ntb@lists.linux.dev, linux-pci@vger.kernel.org, linux-staging@lists.linux.dev, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-sound@vger.kernel.org Date: Thu, 10 Oct 2024 11:12:33 +0200 In-Reply-To: <2024101006-chump-image-e65c@gregkh> References: <20241009083519.10088-1-pstanner@redhat.com> <20241009083519.10088-11-pstanner@redhat.com> <2024100936-brunette-flannels-0d82@gregkh> <411f3c94-58b5-471e-bc58-e23d89d2078f@gmail.com> <2024101006-chump-image-e65c@gregkh> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-1.fc40) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2024-10-10 at 11:03 +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 10, 2024 at 10:03:30AM +0200, Philipp Stanner wrote: > > On Wed, 2024-10-09 at 21:41 +0200, Philipp Hortmann wrote: > > > On 10/9/24 11:38, Greg Kroah-Hartman wrote: > > > > On Wed, Oct 09, 2024 at 10:35:16AM +0200, Philipp Stanner > > > > wrote: > > > > > pci_intx() is a hybrid function which can sometimes be > > > > > managed > > > > > through > > > > > devres. To remove this hybrid nature from pci_intx(), it is > > > > > necessary to > > > > > port users to either an always-managed or a never-managed > > > > > version. > > > > >=20 > > > > > rts5208 enables its PCI-Device with pcim_enable_device(). > > > > > Thus, > > > > > it needs the > > > > > always-managed version. > > > > >=20 > > > > > Replace pci_intx() with pcim_intx(). > > > > >=20 > > > > > Signed-off-by: Philipp Stanner > > > > > --- > > > > > =C2=A0 drivers/staging/rts5208/rtsx.c | 2 +- > > > > > =C2=A0 1 file changed, 1 insertion(+), 1 deletion(-) > > > >=20 > > > > Acked-by: Greg Kroah-Hartman > > > >=20 > > >=20 > > > Hi Philipp, > > >=20 > > > this driver (rts5208) will be removed soon - patch is send in. > > >=20 > > > Discussion about removal: > > > https://lore.kernel.org/linux-staging/2024100943-shank-washed-a765@gr= egkh/T/#t > >=20 > >=20 > > Alright, thx for the heads up. > >=20 > > I'm not entirely how best to deal with that, though. I could drop > > this > > patch, but then the driver would end up with an unmanaged > > pci_intx(). > >=20 > > Might this be a problem for users if my series lands sooner than > > the > > removal, say in v6.13 and your removal in v6.14? >=20 > The removal will happen in 6.13, I'm going to be queueing it up right > now. Alright, thx. Then I drop patch #10. P. >=20 > thanks, >=20 > greg k-h >=20