From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0534AC3F2D1 for ; Mon, 2 Mar 2020 11:35:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D492C2166E for ; Mon, 2 Mar 2020 11:35:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726915AbgCBLff (ORCPT ); Mon, 2 Mar 2020 06:35:35 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:34235 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726470AbgCBLff (ORCPT ); Mon, 2 Mar 2020 06:35:35 -0500 X-Originating-IP: 83.155.44.161 Received: from classic (mon69-7-83-155-44-161.fbx.proxad.net [83.155.44.161]) (Authenticated sender: hadess@hadess.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id E0789C0009; Mon, 2 Mar 2020 11:35:31 +0000 (UTC) Message-ID: <30842bb43aa29e8f1edeadc335e3f792a7a76092.camel@hadess.net> Subject: Re: [PATCH resend 10/10] Input: goodix - Restore config on resume if necessary From: Bastien Nocera To: Hans de Goede , Dmitry Torokhov Cc: linux-input@vger.kernel.org, Dmitry Mastykin Date: Mon, 02 Mar 2020 12:35:31 +0100 In-Reply-To: <20200221164735.508324-10-hdegoede@redhat.com> References: <20200221164735.508324-1-hdegoede@redhat.com> <20200221164735.508324-10-hdegoede@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.35.91 (3.35.91-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Fri, 2020-02-21 at 17:47 +0100, Hans de Goede wrote: > Some devices, e.g the Trekstor Primetab S11B, loose there config over "lose". > a suspend/resume cycle (likely the controller looses power during "loses". > suspend). > > This commit reads back the config version on resume and if matches > the > expected config version it resets the controller and resends the > config > we read back and saved at probe time. > > BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1786317 > BugLink: https://github.com/nexus511/gpd-ubuntu-packages/issues/10 > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199207 > Cc: Dmitry Mastykin > Signed-off-by: Hans de Goede Looks fine apart from the nitpicks. Reviewed-by: Bastien Nocera > --- > drivers/input/touchscreen/goodix.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/input/touchscreen/goodix.c > b/drivers/input/touchscreen/goodix.c > index 0f39c499e3a9..389d3e044f97 100644 > --- a/drivers/input/touchscreen/goodix.c > +++ b/drivers/input/touchscreen/goodix.c > @@ -1232,6 +1232,7 @@ static int __maybe_unused goodix_resume(struct > device *dev) > { > struct i2c_client *client = to_i2c_client(dev); > struct goodix_ts_data *ts = i2c_get_clientdata(client); > + u8 config_ver; > int error; > > if (ts->irq_pin_access_method == irq_pin_access_none) { > @@ -1253,6 +1254,27 @@ static int __maybe_unused goodix_resume(struct > device *dev) > if (error) > return error; > > + error = goodix_i2c_read(ts->client, ts->chip->config_addr, > + &config_ver, 1); > + if (error) > + dev_warn(dev, "Error reading config version: %d, > resetting controller\n", > + error); > + else if (config_ver != ts->config[0]) > + dev_warn(dev, "Config version mismatch %d != %d, > resetting controller\n", > + config_ver, ts->config[0]); Should it really be a warning if it happens regularly? > + > + if (error != 0 || config_ver != ts->config[0]) { > + error = goodix_reset(ts); > + if (error) { > + dev_err(dev, "Controller reset failed.\n"); > + return error; > + } > + > + error = goodix_send_cfg(ts, ts->config, ts->chip- > >config_len); > + if (error) > + return error; > + } > + > error = goodix_request_irq(ts); > if (error) > return error;