From: "Hemanth V" <hemanthv@ti.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-input@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: Merge plans for Staging Synaptics Touchscreen Driver
Date: Mon, 29 Mar 2010 17:25:32 +0530 (IST) [thread overview]
Message-ID: <33474.10.24.255.18.1269863732.squirrel@dbdmail.itg.ti.com> (raw)
In-Reply-To: <20100326144415.GA1591@ucw.cz>
> Hi!
>
>> Are there any plans to merge the synaptics touchscreen driver
>> (drivers/staging/dream/synaptics_i2c_rmi.c) to
>> drivers/input/touchscreen. We are interested in the same
>> since OMAP3 based Zoom boards use this touchscreen.
>
> Plans are, but day job interferes with them.
>
>> Pl add (if required) below tested by for the staging driver.
>
> 1) are you able to use driver in staging?
Yes I am able to use staging driver for single
touch events.
>
> at minimum, non-standard multitouch support needs to be removed before
> merging to input. Do you have time to help?
Could you review the below patch.
Thanks
Hemanth
---
Remove non-standard multi touch support.
Signed-off-by: Hemanth V <hemanthv@ti.com>
diff --git a/drivers/staging/dream/synaptics_i2c_rmi.c b/drivers/staging/dream/synaptics_i2c_rmi.c
index 4de6bc9..34449ad 100644
--- a/drivers/staging/dream/synaptics_i2c_rmi.c
+++ b/drivers/staging/dream/synaptics_i2c_rmi.c
@@ -150,14 +150,6 @@ static void decode_report(struct synaptics_ts_data *ts, u8 *buf)
input_report_abs(ts->input_dev, ABS_Y, pos[0][1]);
}
input_report_abs(ts->input_dev, ABS_PRESSURE, z);
- input_report_abs(ts->input_dev, ABS_TOOL_WIDTH, w);
- input_report_key(ts->input_dev, BTN_TOUCH, finger);
- finger2_pressed = finger > 1 && finger != 7;
- input_report_key(ts->input_dev, BTN_2, finger2_pressed);
- if (finger2_pressed) {
- input_report_abs(ts->input_dev, ABS_HAT0X, pos[1][0]);
- input_report_abs(ts->input_dev, ABS_HAT0Y, pos[1][1]);
- }
input_sync(ts->input_dev);
}
next prev parent reply other threads:[~2010-03-29 11:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 9:28 Merge plans for Staging Synaptics Touchscreen Driver Hemanth V
2010-03-23 14:00 ` Aguirre, Sergio
2010-03-23 14:42 ` Hemanth V
2010-03-26 14:44 ` Pavel Machek
2010-03-29 11:55 ` Hemanth V [this message]
[not found] ` <33474.10.24.255.18.1269863733.squirrel@dbdmail.itg.ti.com>
2010-03-29 12:15 ` Hemanth V
2010-03-29 13:12 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33474.10.24.255.18.1269863732.squirrel@dbdmail.itg.ti.com \
--to=hemanthv@ti.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).