From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hemanth V" Subject: Re: Merge plans for Staging Synaptics Touchscreen Driver Date: Mon, 29 Mar 2010 17:25:32 +0530 (IST) Message-ID: <33474.10.24.255.18.1269863732.squirrel@dbdmail.itg.ti.com> References: <19039.10.24.255.18.1269336516.squirrel@dbdmail.itg.ti.com> <20100326144415.GA1591@ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:47302 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925Ab0C2Lzi (ORCPT ); Mon, 29 Mar 2010 07:55:38 -0400 In-Reply-To: <20100326144415.GA1591@ucw.cz> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Pavel Machek Cc: linux-input@vger.kernel.org, linux-omap@vger.kernel.org > Hi! > >> Are there any plans to merge the synaptics touchscreen driver >> (drivers/staging/dream/synaptics_i2c_rmi.c) to >> drivers/input/touchscreen. We are interested in the same >> since OMAP3 based Zoom boards use this touchscreen. > > Plans are, but day job interferes with them. > >> Pl add (if required) below tested by for the staging driver. > > 1) are you able to use driver in staging? Yes I am able to use staging driver for single touch events. > > at minimum, non-standard multitouch support needs to be removed before > merging to input. Do you have time to help? Could you review the below patch. Thanks Hemanth --- Remove non-standard multi touch support. Signed-off-by: Hemanth V diff --git a/drivers/staging/dream/synaptics_i2c_rmi.c b/drivers/staging/dream/synaptics_i2c_rmi.c index 4de6bc9..34449ad 100644 --- a/drivers/staging/dream/synaptics_i2c_rmi.c +++ b/drivers/staging/dream/synaptics_i2c_rmi.c @@ -150,14 +150,6 @@ static void decode_report(struct synaptics_ts_data *ts, u8 *buf) input_report_abs(ts->input_dev, ABS_Y, pos[0][1]); } input_report_abs(ts->input_dev, ABS_PRESSURE, z); - input_report_abs(ts->input_dev, ABS_TOOL_WIDTH, w); - input_report_key(ts->input_dev, BTN_TOUCH, finger); - finger2_pressed = finger > 1 && finger != 7; - input_report_key(ts->input_dev, BTN_2, finger2_pressed); - if (finger2_pressed) { - input_report_abs(ts->input_dev, ABS_HAT0X, pos[1][0]); - input_report_abs(ts->input_dev, ABS_HAT0Y, pos[1][1]); - } input_sync(ts->input_dev); }