Re: Adding Kernel xpad support for Flydigi Apex 5

[Vicki Pfau <vi@endrift.com>]

Hi Jiri and Brandon,

On 9/12/25 7:14 AM, Jiri Kosina wrote:
> On Fri, 12 Sep 2025, Jiri Kosina wrote:
> 
>> On Fri, 29 Aug 2025, brandon wrote:
>>
>>> Hello,
>>>
>>> This adds support for the Flydigi Apex 5 controller to the xpad kernel module. This has been tested as part of: https://github.com/paroj/xpad/pull/328
>>>
>>> This patch is very small and simple, it simply white lists the controller so it can be used. The trigger and stick mappings are none standard, but SDL has the correct mappings already shipped so it's not a problem in Steam or games I've tried.
>>>
>>> Here is the patch:
>>>
>>> --- linux/drivers/input/joystick/xpad.c.orig 2025-08-29 18:20:56.157442704 +0100
>>> +++ linux/drivers/input/joystick/xpad.c 2025-08-29 18:19:29.539174760 +0100
>>> @@ -422,6 +422,7 @@ static const struct xpad_device {
>>> { 0x3537, 0x1010, "GameSir G7 SE", 0, XTYPE_XBOXONE },
>>> { 0x366c, 0x0005, "ByoWave Proteus Controller", MAP_SHARE_BUTTON, XTYPE_XBOXONE, FLAG_DELAY_INIT },
>>> { 0x3767, 0x0101, "Fanatec Speedster 3 Forceshock Wheel", 0, XTYPE_XBOX },
>>> +	{ 0x37d7, 0x2501, "Flydigi Apex 5", 0, XTYPE_XBOX },
>>> { 0x413d, 0x2104, "Black Shark Green Ghost Gamepad", 0, XTYPE_XBOX360 },
>>> { 0xffff, 0xffff, "Chinese-made Xbox Controller", 0, XTYPE_XBOX },
>>> { 0x0000, 0x0000, "Generic X-Box pad", 0, XTYPE_UNKNOWN }
>>> @@ -578,6 +579,7 @@ static const struct usb_device_id xpad_t
>>> XPAD_XBOX360_VENDOR(0x3537),		/* GameSir Controllers */
>>> XPAD_XBOXONE_VENDOR(0x3537),		/* GameSir Controllers */
>>> XPAD_XBOXONE_VENDOR(0x366c),		/* ByoWave controllers */
>>> +	XPAD_XBOXONE_VENDOR(0x37d7),		/* Flydigi Controllers */
>>> XPAD_XBOX360_VENDOR(0x413d),		/* Black Shark Green Ghost Controller */
>>> { }
>>> };
>>
>> Thanks for the patch.
>>
>> It's however whitespace-damaged, and also is missing a signoff. Could you 
>> please fix that and resubmit, so that I could merge it?
> 
> (sorry, it's not me who should be merging it, but Dmitry Torokhov as an 
> input maintainer -- please CC him as well on the next iteration)
> 

A corrected patch was already submitted by someone else: https://lore.kernel.org/linux-input/20250903165114.2987905-1-lkml@antheas.dev/

Vicki