From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Tony Lindgren <tony@atomide.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"Lopez Cruz, Misael" <misael.lopez@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Girdwood, Liam" <lrg@ti.com>
Subject: Re: [PATCH v5 15/18] ASoC: twl6040: Remove pll and headset mode dependency
Date: Fri, 17 Jun 2011 16:04:34 +0300 [thread overview]
Message-ID: <3587033.yBnh7UpTkW@barack> (raw)
In-Reply-To: <20110617132759.GB4951@sirena.org.uk>
On Friday 17 June 2011 15:27:59 Mark Brown wrote:
> On Mon, Jun 13, 2011 at 07:37:47PM +0300, Peter Ujfalusi wrote:
> > From: Misael Lopez Cruz <misael.lopez@ti.com>
> >
> > Remove dependency between pll (hppll, lppll) and headset power
> > mode (low-power, high-performance), as headset power mode can
> > be used with any pll.
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> but...
>
> > A new control is created to allow headset power mode configuration
> > from userspace. Changing headset power mode during earpiece related
> > usecases is not allowed as earpiece requires HS DAC in HP mode.
>
> Might be nicer to allow the user to set the control given that you'll
> just ignore the configured value anyway if it's not usable right now.
Yeah, we can allow the change, but skip the register updates for use cases
when it is not allowed.
I did spot other issue related to this power mode handling: the DAPM event
handler has been attached to HFDAC, and not to the HSDAC, so the refcounting
is done for a wrong set of DAC... The HFDACs has no relationship with the
Earpiece output (it is connected to HSDACL).
--
Péter
next prev parent reply other threads:[~2011-06-17 13:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 16:37 [PATCH v5 00/18] MFD/ASoC/Input: TWL4030/TWL60X0 changes Peter Ujfalusi
2011-06-13 16:37 ` [PATCH v5 01/18] OMAP: New twl-common for common TWL configuration Peter Ujfalusi
2011-06-13 16:37 ` [PATCH v5 02/18] OMAP4: Move common twl6030 configuration to twl-common Peter Ujfalusi
2011-06-13 16:37 ` [PATCH v5 03/18] OMAP3: Move common twl " Peter Ujfalusi
2011-06-13 16:37 ` [PATCH v5 04/18] OMAP3: Move common regulator " Peter Ujfalusi
2011-06-13 16:37 ` [PATCH v5 05/18] MFD: twl4030-codec: Rename internals from codec to audio Peter Ujfalusi
2011-06-13 16:37 ` [PATCH v5 06/18] MFD: twl4030-codec -> twl4030-audio: Rename the driver Peter Ujfalusi
2011-06-13 16:37 ` [PATCH v5 07/18] MFD: twl4030-audio: Rename platform data Peter Ujfalusi
2011-06-13 16:37 ` [PATCH v5 08/18] mfd: twl6040: Add initial support Peter Ujfalusi
2011-06-13 16:37 ` [PATCH v5 09/18] ASoC: twl6040: Convert into TWL6040 MFD child Peter Ujfalusi
2011-06-13 16:37 ` [PATCH v5 10/18] MFD: twl6040: Change platform data for soc codec driver Peter Ujfalusi
2011-06-13 16:37 ` [PATCH v5 11/18] input: Add initial support for TWL6040 vibrator Peter Ujfalusi
2011-06-13 16:37 ` [PATCH v5 12/18] OMAP4: SDP4430: Add twl6040 vibrator platform support Peter Ujfalusi
2011-06-13 16:37 ` [PATCH v5 13/18] ASoC: twl6040: add all ABE DAIs Peter Ujfalusi
2011-06-17 13:29 ` [alsa-devel] " Mark Brown
2011-06-13 16:37 ` [PATCH v5 14/18] ASoC: twl6040: Support other sample rates in constraints Peter Ujfalusi
2011-06-17 13:22 ` [alsa-devel] " Mark Brown
2011-06-17 13:09 ` Péter Ujfalusi
2011-06-13 16:37 ` [PATCH v5 15/18] ASoC: twl6040: Remove pll and headset mode dependency Peter Ujfalusi
2011-06-17 13:27 ` [alsa-devel] " Mark Brown
2011-06-17 13:04 ` Péter Ujfalusi [this message]
2011-06-13 16:37 ` [PATCH v5 16/18] ASoC: twl6040: set default constraints Peter Ujfalusi
2011-06-17 13:28 ` Mark Brown
2011-06-13 16:37 ` [PATCH v5 17/18] ASoC: twl6040: Configure ramp step based on platform Peter Ujfalusi
2011-06-17 13:29 ` Mark Brown
2011-06-13 16:37 ` [PATCH v5 18/18] OMAP4: SDP4430: Add twl6040 codec platform support Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3587033.yBnh7UpTkW@barack \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).