linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Paul Parsons <lost.distance@yahoo.com>
Cc: philipp.zabel@gmail.com, linux-input@vger.kernel.org
Subject: Re: [PATCH v8] input: Add Synaptics NavPoint (PXA27x SSP/SPI) driver
Date: Wed, 09 May 2012 14:23:54 -0700	[thread overview]
Message-ID: <3680102.m0lTgVbfcu@dtor-d630.eng.vmware.com> (raw)
In-Reply-To: <1336597795.45073.YahooMailClassic@web29017.mail.ird.yahoo.com>

On Wednesday, May 09, 2012 10:09:55 PM Paul Parsons wrote:
> Hello Dmitry,
> 
> --- On Wed, 9/5/12, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> > The driver looks excellent now, I have just a few nits:
> > 
> > - you do not need separate mutex and counter; it is
> > perfectly fine to
> >   use input device's ones;
> > 
> > - we don't really need min/max for coordinates: the defaults
> > are good
> >   for your device and if more devices come with
> > different limits one
> >   could adjust limits via EVIOCSABS ioctls.
> > 
> > I also took libertu if rearranging the code a bit so it
> > flows more like
> > the rest of the input drivers. Could you please tell me if
> > the patch
> > below breaks your device or if it still works?
> 
> It still works! Thanks.
> 
> Will you apply a combined patch (my patch v8 + your patch),
> or should I submit them as patch v9?

If you have not made any changes to the patch I sent then there is no need
to send v9, I'll fold everything together on my end.

Thanks.

-- 
Dmitry

  reply	other threads:[~2012-05-09 21:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16 11:37 [PATCH v8] input: Add Synaptics NavPoint (PXA27x SSP/SPI) driver Paul Parsons
2012-04-16 20:16 ` Philipp Zabel
2012-05-09  8:00 ` Dmitry Torokhov
2012-05-09 21:09   ` Paul Parsons
2012-05-09 21:23     ` Dmitry Torokhov [this message]
2012-05-10  8:51       ` Paul Parsons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3680102.m0lTgVbfcu@dtor-d630.eng.vmware.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=lost.distance@yahoo.com \
    --cc=philipp.zabel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).