From: Zack Rusin <zackr@vmware.com>
To: "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
Pv-drivers <Pv-drivers@vmware.com>,
"zhouzongmin@kylinos.cn" <zhouzongmin@kylinos.cn>,
Linux-graphics-maintainer <Linux-graphics-maintainer@vmware.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: vmmouse - add macros to enable vmmouse relative mode
Date: Fri, 14 Apr 2023 01:22:25 +0000 [thread overview]
Message-ID: <36d0b466c96b42f5fd364c2a80379d6d7be9cb48.camel@vmware.com> (raw)
In-Reply-To: <20230413085635.2515647-1-zhouzongmin@kylinos.cn>
On Thu, 2023-04-13 at 16:56 +0800, Zongmin Zhou wrote:
> Add macros to enable request relative mode.
>
> Change the REL_Y value passed by input_report_rel function,
> to match the direction of mouse movement.
Thanks for the patch, but in its current form it's a nack. First of all we don't
want any defines in the driver code that affect compilation, it's never going to be
tested or compiled in. Either a kconfig or a module parameter would be acceptable
but that's only if you can actually explain what it is that you're fixing. The
current single line description just mentions what the effect it has (not completely
correctly either because for merged packets absolute will still be x=x, y=y, but
relative will be x += dx, y -= dy) but not why it's done, what it's fixing and how
to reproduce.
z
next prev parent reply other threads:[~2023-04-14 1:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 8:56 [PATCH] Input: vmmouse - add macros to enable vmmouse relative mode Zongmin Zhou
2023-04-14 1:22 ` Zack Rusin [this message]
2023-04-14 8:58 ` zongmin zhou
2023-04-14 15:32 ` Zack Rusin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36d0b466c96b42f5fd364c2a80379d6d7be9cb48.camel@vmware.com \
--to=zackr@vmware.com \
--cc=Linux-graphics-maintainer@vmware.com \
--cc=Pv-drivers@vmware.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhouzongmin@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).