From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4701EE49A3 for ; Tue, 22 Aug 2023 16:19:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237644AbjHVQTq (ORCPT ); Tue, 22 Aug 2023 12:19:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237546AbjHVQTq (ORCPT ); Tue, 22 Aug 2023 12:19:46 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9A43193 for ; Tue, 22 Aug 2023 09:19:43 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3fe12820bffso46812475e9.3 for ; Tue, 22 Aug 2023 09:19:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692721182; x=1693325982; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=e2sK25pHmy+ze1Ybz8hn3pPQzDyrBRYa60rRH4NH4K4=; b=EIr1I4lkGWcsjJhSARAeppBKOlivRpYDEKnMMlMqc8br9LSs+W/8+ObH7xmN6/O8mB CEk9ec26vYMXxU1M0Zr1+kTvvkeZmB6JOxDu7UkvfMzIdWBopKpEGT8dmNjIKXwLj3ul 0CnlGGh4HMrIMeFYK7IsgNeL+Wdx4zSePl15f3jdiSJQ7JTY/0aA15J4+gWF4xtgmpof Ufih+szZNwlgZIt/0sFRCPp/BnLx6oFpwqp5Yd5okz5ofoloAxIqdpzD2gXDf85q4xrY 9gklxTxamFUMMpAmkJ5sL6ZAoETDIV1DpNJ++428Fmxc0gJ2bMTM6KW+xHOZmzlXDqVF Iotg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692721182; x=1693325982; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=e2sK25pHmy+ze1Ybz8hn3pPQzDyrBRYa60rRH4NH4K4=; b=dLIw4cJAyBy4B5q8Va6dOxcy26kGETvptxngBCY3T+p/IwfvZo+I0XEPSqAgtkD3In O2LuoRBGKha241ydJPFT+gzbPKe2DThKfjDc7UmyiCs2BM3FSaS7vAP3LAk+sE0tL6NS 4BjdT/67b9ctrtZo9IrmVmaSrUj+7ggudHWm5pRYsJbTWkit4DLFlvKMcBCJHmWb5rUV ZsD/vjJ4+QWh7MAFVadTd0aHJKzNwaAga/u/WLYlkb1qPiQQGVa06MX/AMN0fqmawQnA PipVaFgLhsjQafDO119gRwJOJem8DRTl2a5vu0W+zjUBF3+FhjowirULi1MqzWDQdwxM pQzQ== X-Gm-Message-State: AOJu0YykG2nEr65AIKI8XcTJV1BPwFxoydR1/PWK0gjQCPNx3ZSimgvD 5QmmOpj032J4Xy+J92VIAV/MRg== X-Google-Smtp-Source: AGHT+IFV2T7QA2Y8bKBQIemr3twqEOx//JFK9SnUvRdlu3ELv5Fb8pjW8G6OT+xALpwoMCsJaKtPYQ== X-Received: by 2002:adf:e548:0:b0:317:5c82:10c5 with SMTP id z8-20020adfe548000000b003175c8210c5mr7196004wrm.17.1692721182281; Tue, 22 Aug 2023 09:19:42 -0700 (PDT) Received: from ?IPV6:2a01:e0a:cad:2140:de4a:6da8:c7fc:12c? ([2a01:e0a:cad:2140:de4a:6da8:c7fc:12c]) by smtp.gmail.com with ESMTPSA id y17-20020a5d4ad1000000b0031984b370f2sm16289955wrs.47.2023.08.22.09.19.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Aug 2023 09:19:41 -0700 (PDT) Message-ID: <36efbd0b-7f33-4c11-8e8e-f07bea4b3455@linaro.org> Date: Tue, 22 Aug 2023 18:19:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v5 0/4] input: touchscreen: add initial support for Goodix Berlin touchscreen IC Content-Language: en-US, fr To: Dmitry Torokhov , Bastien Nocera , Hans de Goede , Henrik Rydberg , Jeff LaBundy Cc: linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring References: <20230801-topic-goodix-berlin-upstream-initial-v5-0-079252935593@linaro.org> Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Developer Services In-Reply-To: <20230801-topic-goodix-berlin-upstream-initial-v5-0-079252935593@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi, On 01/08/2023 14:15, Neil Armstrong wrote: > These touchscreen ICs support SPI, I2C and I3C interface, up to > 10 finger touch, stylus and gestures events. > > This initial driver is derived from the Goodix goodix_ts_berlin > available at [1] and [2] and only supports the GT9916 IC > present on the Qualcomm SM8550 MTP & QRD touch panel. > > The current implementation only supports BerlinD, aka GT9916. > > Support for advanced features like: > - Firmware & config update > - Stylus events > - Gestures events > - Previous revisions support (BerlinA or BerlinB) > is not included in current version. > > The current support will work with currently flashed firmware > and config, and bail out if firmware or config aren't flashed yet. Gentle ping, is there any changes to be made in order to get this driver in ? Thanks, Neil > > [1] https://github.com/goodix/goodix_ts_berlin > [2] https://git.codelinaro.org/clo/la/platform/vendor/opensource/touch-drivers > > Signed-off-by: Neil Armstrong > --- > Changes in v5: > - rebased on next-20230801 > - Link to v4: https://lore.kernel.org/r/20230606-topic-goodix-berlin-upstream-initial-v4-0-0947c489be17@linaro.org > > Changes in v4: > - Core updates: > - drop kconfig depends, deps will be handled by _SPI and _I2C > - change power_on() error labels > - print errors on all dev_err() prints > - remove useless default variable initialization > - switch irq touch checksum error to dev_err() > - add Jeff's review tag > - I2C changes > - change REGMAP_I2C Kconfig from depends to select > - add Jeff's review tag > - SPI changes > - add select REGMAP to Kconfig > - added GOODIX_BERLIN_ prefix to defines > - switched from ret to error > - add Jeff's review tag > - Link to v3: https://lore.kernel.org/r/20230606-topic-goodix-berlin-upstream-initial-v3-0-f0577cead709@linaro.org > > Changes in v3: > - Another guge cleanups after Jeff's review: > - appended goodix_berlin_ before all defines > - removed some unused defines > - removed retries on most of read functions, can be added back later > - added __le to ic_info structures > - reworked and simplified irq handling, dropped enum and ts_event structs > - added struct for touch data > - simplified and cleaned goodix_berlin_check_checksum & goodix_berlin_is_dummy_data > - moved touch_data_addr to the end of the main code_data > - reworked probe to get_irq last and right before setip input device > - cleaned probe by removing the "cd->dev" > - added short paragraph to justify new driver for berlin devices > - defined all offsets & masks > - Added bindings review tag > - Link to v2: https://lore.kernel.org/r/20230606-topic-goodix-berlin-upstream-initial-v2-0-26bc8fe1e90e@linaro.org > > Changes in v2: > - Huge cleanups after Jeff's review: > - switch to error instead of ret > - drop dummy vendor/product ids > - drop unused defined/enums > - drop unused ic_info and only keep needes values > - cleanup namings and use goodix_berlin_ everywhere > - fix regulator setup > - fix default variables value when assigned afterwars > - removed indirections > - dropped debugfs > - cleaned input_dev setup > - dropped _remove() > - sync'ed i2c and spi drivers > - fixed yaml bindings > - Link to v1: https://lore.kernel.org/r/20230606-topic-goodix-berlin-upstream-initial-v1-0-4a0741b8aefd@linaro.org > > --- > Neil Armstrong (4): > dt-bindings: input: document Goodix Berlin Touchscreen IC > input: touchscreen: add core support for Goodix Berlin Touchscreen IC > input: touchscreen: add I2C support for Goodix Berlin Touchscreen IC > input: touchscreen: add SPI support for Goodix Berlin Touchscreen IC > > .../bindings/input/touchscreen/goodix,gt9916.yaml | 95 ++++ > drivers/input/touchscreen/Kconfig | 31 ++ > drivers/input/touchscreen/Makefile | 3 + > drivers/input/touchscreen/goodix_berlin.h | 159 ++++++ > drivers/input/touchscreen/goodix_berlin_core.c | 581 +++++++++++++++++++++ > drivers/input/touchscreen/goodix_berlin_i2c.c | 69 +++ > drivers/input/touchscreen/goodix_berlin_spi.c | 173 ++++++ > 7 files changed, 1111 insertions(+) > --- > base-commit: a734662572708cf062e974f659ae50c24fc1ad17 > change-id: 20230606-topic-goodix-berlin-upstream-initial-ba97e8ec8f4c > > Best regards,