From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Stephen Warren <swarren@nvidia.com>
Cc: Shridhar Rasal <srasal@nvidia.com>,
"rydberg@euromail.se" <rydberg@euromail.se>,
Rakesh Iyer <riyer@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 1/1] input: keyboard: Set configuration registers
Date: Fri, 09 Dec 2011 13:25:06 -0800 [thread overview]
Message-ID: <3849551.l2KNPKMSmh@dtor-d630.eng.vmware.com> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF1751860550@HQMAIL01.nvidia.com>
On Friday, December 09, 2011 12:10:43 PM Stephen Warren wrote:
> Shridhar Rasal wrote at Friday, December 09, 2011 12:29 AM:
> > To: dmitry.torokhov@gmail.com
> > Cc: rydberg@euromail.se; Stephen Warren; Rakesh Iyer;
> > linux-kernel@vger.kernel.org; linux- input@vger.kernel.org;
> > linux-tegra@vger.kernel.org; Shridhar Rasal Subject: [PATCH 1/1] input:
> > keyboard: Set configuration registers
> >
> > -Set only REQUIRED row and column configuration register to
> > PROPER values to avoid continuously generating KBC input events.
> > -Use *en* field in pin_cfg, to check GPIO_x_ROW_EN register
> > should be set or clear.
> >
> > Signed-off-by: Shridhar Rasal <srasal@nvidia.com>
>
> I wondered if num==0 could be used instead of a new en field, but 0 is a
> valid row/column number, so no. As such,
>
> Acked-by: Stephen Warren <swarren@nvidia.com>
Can we pass in number of pin_cfg instances in pdata and simply do not
mention unneeded pins instead?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2011-12-09 21:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 7:29 [PATCH 1/1] input: keyboard: Set configuration registers Shridhar Rasal
2011-12-09 20:10 ` Stephen Warren
2011-12-09 21:25 ` Dmitry Torokhov [this message]
2011-12-09 23:17 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF17518605E5-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-12-30 3:25 ` Dmitry Torokhov
2012-01-31 19:09 ` Dmitry Torokhov
2012-01-31 19:29 ` Stephen Warren
2012-01-31 19:47 ` Dmitry Torokhov
2012-01-31 19:51 ` Stephen Warren
[not found] ` <20120131194735.GA22872-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2012-03-27 5:17 ` Shridhar Rasal
[not found] ` <4F714D5C.1050400-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-03-27 15:22 ` Stephen Warren
2012-03-29 15:49 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3849551.l2KNPKMSmh@dtor-d630.eng.vmware.com \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=riyer@nvidia.com \
--cc=rydberg@euromail.se \
--cc=srasal@nvidia.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).