Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

["Bryan Wu" <cooloney.lkml@gmail.com>]

On 10/16/07, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> On 10/15/07, Bryan Wu <cooloney.lkml@gmail.com> wrote:
> > On 10/15/07, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> > >
> > > Completion is just not a good abstraction here... Please use work
> > > abstraction and possibly a separate workqueue.
> >
> > Yes, I agree with you now, although I have a little concern about the
> > possibility of big delay introduced by workqueue.
> >
>
> Having a separate workqueue should isolate the driver from users
> hogging keventd. Otherwise the speed should be pretty much the same as
> with a kthread.
>

Does this driver need the create a new kthread instead of keventd?
I think keventd might be sufficient for this driver.

> >
> > Thanks a lot for you kindly review.
> > I will resend update patch later.
>
> Thank you for not getting frustrated with all my change requests.

Oh, your help is very useful. It encourages us to send out our drivers
to LKML.

> Btw,
> blackfin keypad driver is in my tree and should be in mainline once
> Linus does the pull I requested.
>

Thanks again, I noticed it was merged already.

-Bryan Wu