linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Bryan Wu" <cooloney@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: khali@linux-fr.org, andre@bitwigglers.org,
	linux-input@vger.kernel.org, i2c@lm-sensors.org,
	linux-kernel@vger.kernel.org, vapier.adi@gmail.com,
	Michael Hennerich <michael.hennerich@analog.com>
Subject: Re: [PATCH 1/1] Input/Joystick Driver: add support AD7142 joystick driver (v2)
Date: Fri, 25 Apr 2008 18:09:52 +0800	[thread overview]
Message-ID: <386072610804250309j5f2222cfj2f58b3b92d091a3a@mail.gmail.com> (raw)
In-Reply-To: <20080418131149.ZZRA012@mailhub.coreip.homeip.net>

On Sat, Apr 19, 2008 at 1:15 AM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> Hi Bryan,
>
>
>  On Thu, Mar 27, 2008 at 11:38:30AM -0700, Bryan Wu wrote:
>  > +     input->keybit[BIT_WORD(BTN_BASE)] = BIT_MASK(BTN_BASE) |
>  > +                                             BIT_MASK(BTN_BASE2) |
>  > +                                             BIT_MASK(BTN_BASE3) |
>  > +                                             BIT_MASK(BTN_BASE4);
>  > +     input->keybit[BIT_WORD(KEY_UP)] |=  BIT_MASK(KEY_UP) |
>  > +                                             BIT_MASK(KEY_DOWN) |
>  > +                                             BIT_MASK(KEY_LEFT) |
>  > +                                             BIT_MASK(KEY_RIGHT);
>  > +
>
>  Why don't you use REL_X/REL_Y to report directional movement? Using
>  buttons for that is pretty unusual.
>

In our development board, it includes UP/DOWN/LEFT/RIGHT 4 buttons. So
this driver matches this.
Please found some information about the hardware as below:
http://docs.blackfin.uclinux.org/doku.php?id=capacitance_touch_sensors&s[]=ad7142

Thanks
-Bryan

  reply	other threads:[~2008-04-25 10:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-27 18:38 [PATCH 1/1] Input/Joystick Driver: add support AD7142 joystick driver (v2) Bryan Wu
     [not found] ` <1206643110-8789-1-git-send-email-cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2008-04-18 17:15   ` Dmitry Torokhov
2008-04-25 10:09     ` Bryan Wu [this message]
2008-04-25 15:39       ` Dmitry Torokhov
2008-04-27  1:09         ` [PATCH 1/1] Input/Joystick Driver: add support AD7142 joystickdriver (v2) Robin Getz
2008-04-27 13:52         ` [PATCH 1/1] Input/Joystick Driver: add support AD7142 joystick driver (v2) Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=386072610804250309j5f2222cfj2f58b3b92d091a3a@mail.gmail.com \
    --to=cooloney@kernel.org \
    --cc=andre@bitwigglers.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=i2c@lm-sensors.org \
    --cc=khali@linux-fr.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).