From: "johann deneux" <johann.deneux@gmail.com>
To: Dmitry Torokhov <dtor@insightbb.com>
Cc: linux-input@atrey.karlin.mff.cuni.cz,
linux-usb-devel@lists.sourceforge.net
Subject: Re: [PATCH] iforce: Use usb_kill_urb instead of usb_unlink_urb.
Date: Sun, 18 Mar 2007 09:01:28 +0100 [thread overview]
Message-ID: <38b3b7c0703180101hef6b82cn9c920eb20edade7f@mail.gmail.com> (raw)
In-Reply-To: <200703172137.23385.dtor@insightbb.com>
Hi Dmitry,
On 3/18/07, Dmitry Torokhov <dtor@insightbb.com> wrote:
> Hi Johann,
>
> On Saturday 17 March 2007 17:50, johann deneux wrote:
> > A note about that patch: Apparently Anders Fugmann submitted a patch to use
> > usb_kill_urb to linux-usb-devel for version 2.6.10.
> > I don't know if this patch got lost, or if it was rejected.
>
> Since every other USB dirver uses usb_kill_urb it loosk like the patch was
> just missed...
>
> >
> > On 3/17/07, johann deneux <johann.deneux@gmail.com> wrote:
> > >
> > > commit 0ba8785483c2ee7f56e8f242e000f6cd17a7da40
> > > Author: Johann Deneux <johann.deneux@gmail.com>
> > > Date: Sat Mar 17 22:23:44 2007 +0100
> > >
> > > iforce: Use usb_kill_urb instead of usb_unlink_urb.
> > >
> > > Using usb_unlink_urb can cause iforce_open to fail when called soon
> > > after iforce_release.
> > > Also updated my email address and replaced calls to printk() by dbg(),
> > > warn(), info(), err()...
> > >
>
> Since there seems a lot of implementations of r warn(), err(), etc what kind
> of output would iforce produce?
>
It uses the implementation from include/linux/usb.h. The output from
the module should be approximately the same as before, except for
debug messages which were previously inconditionally produced, and are
now produced only when macro DEBUG is defined and non-zero.
Macros warn(), dbg()... in usb.h use printk KERN_WARNING, KERN_DEBUG...
--
Johann
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
next prev parent reply other threads:[~2007-03-18 8:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <38b3b7c0703171439n10025a7bx55a588911eb765d6@mail.gmail.com>
2007-03-17 21:43 ` [PATCH] iforce: Use usb_kill_urb instead of usb_unlink_urb johann deneux
2007-03-17 21:50 ` johann deneux
2007-03-18 1:37 ` Dmitry Torokhov
2007-03-18 8:01 ` johann deneux [this message]
2007-03-19 16:18 ` Dmitry Torokhov
2007-03-19 20:49 ` johann deneux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38b3b7c0703180101hef6b82cn9c920eb20edade7f@mail.gmail.com \
--to=johann.deneux@gmail.com \
--cc=dtor@insightbb.com \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).