public inbox for linux-input@vger.kernel.org
 help / color / mirror / Atom feed
From: Henrik Rydberg <rydberg@bitmath.se>
To: Liam Mitchell <mitchell.liam@gmail.com>,
	Henrik Rydberg <rydberg@bitmath.org>
Cc: linux-input@vger.kernel.org
Subject: Re: bcm5974 trackpad broken after USB reset
Date: Sun, 11 Jan 2026 20:59:44 +0100	[thread overview]
Message-ID: <38ea07c1-50ce-4342-aba9-fe2f4bc6c503@bitmath.se> (raw)
In-Reply-To: <CAOQ1CL4+DP1TuLAGNsz5GdFBTHvnTg=5q=Dr2Z1OQc6RXydSYA@mail.gmail.com>

Hi Liam,

 > The trackpad on my 2013 MacBook Pro (10,2) stops working after the USB
> device is reset, logging "bad trackpad package, length: 8" when
> touching the trackpad.

This sounds like the device has left wellspring mode, and is not 
properly reinitialized after reset. It has been a decade since I worked 
on this driver, but what I can see, there is no reset_resume handler in 
bcm5974, but there is one in appletouch.

I would look into the code around the wellspring mode switch function, 
and see if it gets called after the usb reset. If not, adding the 
reset_resume handler might resolve things.

Hope this helps,
Henrik


  reply	other threads:[~2026-01-11 20:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-11 17:28 bcm5974 trackpad broken after USB reset Liam Mitchell
2026-01-11 19:59 ` Henrik Rydberg [this message]
2026-01-17 13:44   ` Liam Mitchell
2026-01-18  3:33     ` Henrik Rydberg
2026-01-18  9:59       ` Liam Mitchell
     [not found]       ` <CAOQ1CL74A+WLY_f+QJHQqV=Wvq8yzJktLZ2ByZ4vjfUSsra9EQ@mail.gmail.com>
     [not found]         ` <c2f1a90e-d6cb-480e-8f11-240b231adc84@bitmath.se>
2026-01-25 16:29           ` Liam Mitchell
2026-01-26 22:20             ` Henrik Rydberg
2026-01-27 18:25               ` Liam Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38ea07c1-50ce-4342-aba9-fe2f4bc6c503@bitmath.se \
    --to=rydberg@bitmath.se \
    --cc=linux-input@vger.kernel.org \
    --cc=mitchell.liam@gmail.com \
    --cc=rydberg@bitmath.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox