From: "Silvan Jegen" <s.jegen@gmail.com>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: "Daniel J . Ogorchock" <djogorchock@gmail.com>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: nintendo: deregister home LED when it fails
Date: Mon, 18 Apr 2022 16:17:11 +0200 [thread overview]
Message-ID: <39QNT1MSMJLC1.2M2V40UQZFSEE@homearch.localdomain> (raw)
In-Reply-To: <20220415100432.23453-1-icenowy@aosc.io>
Hi
Icenowy Zheng <icenowy@aosc.io> wrote:
> Some Pro Controller compatible controllers do not support home LED, and
> will fail when setting it. Currently this leads to probe failure.
>
> Change the code that fails probing to deregistering home LED.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
Reviewed-by: Silvan Jegen <s.jegen@gmail.com>
I don't have a "Nintendo Pro Controller"-compatible controller to test
with but I have compiled a Kernel with this patch applied and can confirm
that the original Nintendo Pro Controller is still probed correctly with
this patch applied.
Cheers,
Silvan
next prev parent reply other threads:[~2022-04-18 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 10:04 [PATCH] HID: nintendo: deregister home LED when it fails Icenowy Zheng
2022-04-18 14:17 ` Silvan Jegen [this message]
2022-07-20 18:47 ` Nils Helmig
2022-09-20 22:09 ` Daniel Ogorchock
2022-09-21 8:57 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39QNT1MSMJLC1.2M2V40UQZFSEE@homearch.localdomain \
--to=s.jegen@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=djogorchock@gmail.com \
--cc=icenowy@aosc.io \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox