From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D09FC433EF for ; Wed, 6 Jul 2022 20:40:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233964AbiGFUkt (ORCPT ); Wed, 6 Jul 2022 16:40:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233289AbiGFUks (ORCPT ); Wed, 6 Jul 2022 16:40:48 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4D6F51E3FF for ; Wed, 6 Jul 2022 13:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657140047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hyj4lprFz5j3abxu3sXetpyRdsBIBJWEFHqu1EF5qFQ=; b=JgRY8hJAT/tyWBoIK3crC6DAbt6y4OJpd4nc2ozhYXgWpUNitPSggBz/IWArvGyyjHwHqC D7W/i4fnL8qIq2TAkbLQh6HqZ/jWzf0YL0vkdyOPNiSdrpXX2Xz1q6OIZei7TK//YSDmz4 ZPgWaAbSViBRUTjItiRRgL5fCiuHWUQ= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-187-nRcgqWH5NcyNLKuJRZfEzA-1; Wed, 06 Jul 2022 16:40:43 -0400 X-MC-Unique: nRcgqWH5NcyNLKuJRZfEzA-1 Received: by mail-ej1-f71.google.com with SMTP id sd14-20020a1709076e0e00b0072a7c5a08f4so4188923ejc.21 for ; Wed, 06 Jul 2022 13:40:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Hyj4lprFz5j3abxu3sXetpyRdsBIBJWEFHqu1EF5qFQ=; b=Z7qgrZWEbARAtg+9MrUFnFA55U6kVf6EAofT4WyUMykgA4nCR1dPgdCKcL2qTCNin4 YRi7LQcXn8PJy3XpEwM6iQCBijkw8wDcYGENLSZook7RVGIOU8RxOo1ZkwhDjM2TU7fL S/MVUx0VFFPhoI5YQ/70WKwTI1fkEuQgKrWZYn+sc7pJZFEYRSsrvupWtzoHHesDTIET aD7YR81yzun99FP5wg6z8yEcoYOoKsc3LbDJIubzwxedlSXWnslB1PatCmAy9xiFMPoQ w5C2CgHCB0Aa52pOligY2Zz6Pg99gUaCTs2cJQvV7tL3BghYNpNJG7rIlcPukVYzu4/v abag== X-Gm-Message-State: AJIora9G2WzSXmss8ZzyHGf4SyYIz5as0IRZI+QuYiYyGMCFI8+DrgSL pqM+1J2Iojx14XqT1MtVDbhkD7A+c+LUw22LarCV5GI+lwDKcECsEZFi6sFu/VHrco09fXVKZZ3 YeDA1gxAnQFQeWoPK2OGnn6Y= X-Received: by 2002:a17:906:149:b0:712:c8:fa53 with SMTP id 9-20020a170906014900b0071200c8fa53mr40141711ejh.563.1657140042175; Wed, 06 Jul 2022 13:40:42 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u4UxV9JkVpXBsgVNdKHL/2t8bVeLlPY0ym46/GikBxF0WczYd8pgBk7Yq7f4iS+eixslN5hQ== X-Received: by 2002:a17:906:149:b0:712:c8:fa53 with SMTP id 9-20020a170906014900b0071200c8fa53mr40141695ejh.563.1657140041983; Wed, 06 Jul 2022 13:40:41 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id z10-20020aa7c64a000000b0043a21e3b4a5sm9211675edr.40.2022.07.06.13.40.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 13:40:41 -0700 (PDT) Message-ID: <39d56706-3fa8-bd3d-e661-6be91b8a2ea4@redhat.com> Date: Wed, 6 Jul 2022 22:40:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v1 1/1] Input: goodix - switch use of acpi_gpio_get_*_resource() APIs Content-Language: en-US To: Andy Shevchenko , Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bastien Nocera References: <20220705180252.963-1-andriy.shevchenko@linux.intel.com> From: Hans de Goede In-Reply-To: <20220705180252.963-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi, On 7/5/22 20:02, Andy Shevchenko wrote: > No need to open code functionality that is provided by the > acpi_gpio_get_irq_resource() and acpi_gpio_get_io_resource(). > > Signed-off-by: Andy Shevchenko Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/input/touchscreen/goodix.c | 22 ++++++++-------------- > 1 file changed, 8 insertions(+), 14 deletions(-) > > diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c > index 3ad9870db108..cc52f0d21dbb 100644 > --- a/drivers/input/touchscreen/goodix.c > +++ b/drivers/input/touchscreen/goodix.c > @@ -822,22 +822,16 @@ static int goodix_resource(struct acpi_resource *ares, void *data) > struct device *dev = &ts->client->dev; > struct acpi_resource_gpio *gpio; > > - switch (ares->type) { > - case ACPI_RESOURCE_TYPE_GPIO: > - gpio = &ares->data.gpio; > - if (gpio->connection_type == ACPI_RESOURCE_GPIO_TYPE_INT) { > - if (ts->gpio_int_idx == -1) { > - ts->gpio_int_idx = ts->gpio_count; > - } else { > - dev_err(dev, "More then one GpioInt resource, ignoring ACPI GPIO resources\n"); > - ts->gpio_int_idx = -2; > - } > + if (acpi_gpio_get_irq_resource(ares, &gpio)) { > + if (ts->gpio_int_idx == -1) { > + ts->gpio_int_idx = ts->gpio_count; > + } else { > + dev_err(dev, "More then one GpioInt resource, ignoring ACPI GPIO resources\n"); > + ts->gpio_int_idx = -2; > } > ts->gpio_count++; > - break; > - default: > - break; > - } > + } else if (acpi_gpio_get_io_resource(ares, &gpio)) > + ts->gpio_count++; > > return 0; > }