From: John Garry <john.garry@huawei.com>
To: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Cc: "linuxarm@openeuler.org" <linuxarm@openeuler.org>,
Daniel Quinlan <quinlan@pathname.com>,
Vojtech Pavlik <vojtech@suse.cz>
Subject: Re: [Linuxarm] [PATCH v2] input - mk712: remove the driver as it is obsolete and causes kernel crash
Date: Wed, 13 Jan 2021 09:27:44 +0000 [thread overview]
Message-ID: <39ddc462-766a-383a-1b7d-c5de5e203073@huawei.com> (raw)
In-Reply-To: <1758f0370ffc46499077d4e261dbde53@hisilicon.com>
On 12/01/2021 21:54, Song Bao Hua (Barry Song) wrote:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/dr
>> ivers/hwmon/Kconfig?h=v5.11-rc3#n551
>>
>> But not a great solution.
> Yep. It looks buggy as powerpc and arm64 could have the device literally
> though practically people might not use them.
>
>> I tried to guard against it in this series, but never got it over the line:
>> https://lore.kernel.org/linux-pci/1560262374-67875-1-git-send-email-john.g
>> arry@huawei.com/
> Cool. I didn't realize you have tried to figure out a patchset
> to fix it in common code. It seems it is worth revisiting the
> patchset?
>
So that patchset would stop the system crashing when there is no IO port
mapped upon access. But I still did not like how those drivers
unconditionally access those ports, which could have side-effects when
some PCI IO port is mapped to the same IO port address.
Anyway, I'll look again at it.
Thanks,
John
prev parent reply other threads:[~2021-01-13 9:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 5:51 [PATCH v2] input - mk712: remove the driver as it is obsolete and causes kernel crash Barry Song
2021-01-12 10:54 ` [Linuxarm] " John Garry
2021-01-12 21:54 ` Song Bao Hua (Barry Song)
2021-01-13 9:27 ` John Garry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39ddc462-766a-383a-1b7d-c5de5e203073@huawei.com \
--to=john.garry@huawei.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=quinlan@pathname.com \
--cc=song.bao.hua@hisilicon.com \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox