From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B378C77B61 for ; Fri, 28 Apr 2023 10:10:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346021AbjD1KKH (ORCPT ); Fri, 28 Apr 2023 06:10:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345977AbjD1KKG (ORCPT ); Fri, 28 Apr 2023 06:10:06 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0896846BE for ; Fri, 28 Apr 2023 03:10:05 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3f182d745deso95908545e9.0 for ; Fri, 28 Apr 2023 03:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682676603; x=1685268603; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1NdndAiTXiWNg2u0YXHfQ8keyIiYpuxm3CvU9zlYpN0=; b=AtNydsNZz7DITiVM0EZYBpno41WmsQE+AmiWQcnaOQhCE0hBAXPcFuAD/xUnR8Bv2Y JUGou4a5WAJP+YnIfDk7nUPhjip4z58IedvOeVJM3iW4vW0MeTl3bNTUcN6i/2gCiX3M I6Tw0jyZEA88VAJNp9XA7qw15zUlJ5Ih1eQ94xsPNX58vGtqfTQQzuJXemq2+uECAZ2k /yv+NOwoMUzA8uGf77XAV/HveBwsaJ+peSc/gyXPz5lgsxkVuEHoJ/htRMVY03iPDAra KGDy78En7flIUd1dZYcpyhaF2CizBoYJZKdgJW4crpr3aTtQi0TFfZrukcZiUhYuGHsn 0+Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682676603; x=1685268603; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1NdndAiTXiWNg2u0YXHfQ8keyIiYpuxm3CvU9zlYpN0=; b=Etu6XtMzjtWH4ItrnC4SW7mteNjBxE9yRTSoYOWXfqzA45gRN9x3+ADhSvlEAWL7B4 XI1MR7GZUgyLgmdOTLdvp8n1IUlw1ivFGNhNKfSesn7dE051sdmLLtEYxkh4ADc/2NZU CPLxeoKakBy4xYrq0AefLs5WauOFaEbJvFcGTtvoOtZGnVH+uhpY4/eKJ3pCmgOxjfWr CXhTBTVkV0i6fU9S17Ypnm4lxT4LDngNcZycgeT3Y0jYhvYgzFdKlEugNqCWNtAuwT8k gefir3PI46nmaaR4Qo7GLH0vA6s2QnL+/DT5oa3/1gFJjMQ7wYsFXfnDBsCJzltFPRiG /RBw== X-Gm-Message-State: AC+VfDzUqSSGv2PCrxkTvZo2mbYzratdTcAy9OVy/0p8Xu2DyjThwcqZ x/EllTMNeu0s9zBisDb+ljz7wQ== X-Google-Smtp-Source: ACHHUZ5GI8YBzZGl5b2BCGJn7Z5rpx8+kgTSSrDTPJ/Bhju7qpO0y+i7u38R0tXwpEKW2llLnrtYNg== X-Received: by 2002:adf:ef4b:0:b0:2f8:67ee:5ca9 with SMTP id c11-20020adfef4b000000b002f867ee5ca9mr3227987wrp.65.1682676603455; Fri, 28 Apr 2023 03:10:03 -0700 (PDT) Received: from [172.23.3.169] ([195.167.132.10]) by smtp.gmail.com with ESMTPSA id i1-20020a05600011c100b002cff06039d7sm20616598wrx.39.2023.04.28.03.10.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Apr 2023 03:10:02 -0700 (PDT) Message-ID: <3a0bf8d2-957d-63cc-e60d-7225a2c52a7c@linaro.org> Date: Fri, 28 Apr 2023 11:10:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/4] dt-bindings: input: pwm-vibrator: Add enable-gpio Content-Language: en-US To: Luca Weiss , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Sebastian Reichel , Andy Gross , Bjorn Andersson , Konrad Dybcio , Brian Masney Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230427-hammerhead-vibra-v1-0-e87eeb94da51@z3ntu.xyz> <20230427-hammerhead-vibra-v1-1-e87eeb94da51@z3ntu.xyz> From: Caleb Connolly In-Reply-To: <20230427-hammerhead-vibra-v1-1-e87eeb94da51@z3ntu.xyz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 27/04/2023 21:34, Luca Weiss wrote: > Some pwm vibrators have a dedicated enable GPIO that needs to be set > high so that the vibrator works. Document that. > > Signed-off-by: Luca Weiss Reviewed-by: Caleb Connolly > --- > Documentation/devicetree/bindings/input/pwm-vibrator.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/pwm-vibrator.yaml b/Documentation/devicetree/bindings/input/pwm-vibrator.yaml > index d32716c604fe..6398534b43c3 100644 > --- a/Documentation/devicetree/bindings/input/pwm-vibrator.yaml > +++ b/Documentation/devicetree/bindings/input/pwm-vibrator.yaml > @@ -32,6 +32,8 @@ properties: > minItems: 1 > maxItems: 2 > > + enable-gpios: true > + > vcc-supply: true > > direction-duty-cycle-ns: >