From: Matthias Brugger <matthias.bgg@gmail.com>
To: Alexandre Mergnat <amergnat@baylibre.com>,
Flora Fu <flora.fu@mediatek.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Tianping Fang <tianping.fang@mediatek.com>,
Fabien Parent <fabien.parent@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Mark Brown <broonie@kernel.org>,
Sean Wang <sean.wang@mediatek.com>,
Chen Zhong <chen.zhong@mediatek.com>, Pavel Machek <pavel@ucw.cz>,
Lee Jones <lee@kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh@kernel.org>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-leds@vger.kernel.org, Fabien Parent <fparent@baylibre.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-rtc@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v5 07/10] arm64: dts: mt6358: change node names
Date: Thu, 17 Nov 2022 17:02:51 +0100 [thread overview]
Message-ID: <3ab0a069-355c-b3a7-450b-22e58d5f1ea8@gmail.com> (raw)
In-Reply-To: <20221005-mt6357-support-v5-7-8210d955dd3d@baylibre.com>
On 16/11/2022 13:33, Alexandre Mergnat wrote:
> - Change the node name from "mt6358" to "pmic" to be consistent
> with mediatek,pwrap.yaml documentation.
>
> - Change the node name from "mt6358rtc" to "rtc" to be consistent
> with mediatek,mt6397-rtc.yaml documentation.
>
> - Change the node name from "mt6358keys" to "keys" to be consistent
> with mediatek,pmic-keys.yaml documentation.
>
I think the node names should be changed anyway. So I'd advise to update the
commit message and I can take some right away.
Regards,
Matthias
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> arch/arm64/boot/dts/mediatek/mt6358.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt6358.dtsi b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> index 98f3b0e0c9f6..b605313bed99 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> @@ -5,7 +5,7 @@
> #include <dt-bindings/input/input.h>
>
> &pwrap {
> - pmic: mt6358 {
> + pmic: pmic {
> compatible = "mediatek,mt6358";
> interrupt-controller;
> interrupt-parent = <&pio>;
> @@ -355,11 +355,11 @@ mt6358_vsim2_reg: ldo_vsim2 {
> };
> };
>
> - mt6358rtc: mt6358rtc {
> + mt6358rtc: rtc {
> compatible = "mediatek,mt6358-rtc";
> };
>
> - mt6358keys: mt6358keys {
> + mt6358keys: keys {
> compatible = "mediatek,mt6358-keys";
> power {
> linux,keycodes = <KEY_POWER>;
>
next prev parent reply other threads:[~2022-11-17 16:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 12:32 [PATCH v5 00/10] Add MediaTek MT6357 PMIC support Alexandre Mergnat
2022-11-16 12:32 ` [PATCH v5 01/10] dt-bindings: input: mtk-pmic-keys: add binding for MT6357 PMIC Alexandre Mergnat
2022-11-16 12:32 ` [PATCH v5 02/10] dt-bindings: rtc: mediatek: convert MT6397 rtc documentation Alexandre Mergnat
2022-11-17 15:39 ` Rob Herring
2022-11-16 12:32 ` [PATCH v5 03/10] dt-bindings: rtc: mediatek: add MT6357 support Alexandre Mergnat
2022-11-20 16:44 ` Rob Herring
2022-11-16 12:32 ` [PATCH v5 04/10] regulator: dt-bindings: Add binding schema for mt6357 regulators Alexandre Mergnat
2022-11-16 12:32 ` [PATCH v5 05/10] dt-bindings: mfd: mediatek: Add bindings for MT6357 PMIC Alexandre Mergnat
2022-11-16 16:03 ` Rob Herring
2022-11-16 16:26 ` Alexandre Mergnat
2022-11-16 12:33 ` [PATCH v5 06/10] dt-bindings: soc: mediatek: convert pwrap documentation Alexandre Mergnat
2022-11-17 16:00 ` Rob Herring
2022-11-17 16:06 ` Matthias Brugger
2022-11-22 8:14 ` Alexandre Mergnat
2022-11-22 15:37 ` Alexandre Mergnat
2022-11-16 12:33 ` [PATCH v5 07/10] arm64: dts: mt6358: change node names Alexandre Mergnat
2022-11-17 16:02 ` Matthias Brugger [this message]
2022-11-16 12:33 ` [PATCH v5 08/10] arm64: dts: mt8173: change node name Alexandre Mergnat
2022-11-17 15:56 ` Matthias Brugger
2022-11-16 12:33 ` [PATCH v5 09/10] regulator: add mt6357 regulator Alexandre Mergnat
2022-11-16 14:17 ` Matti Vaittinen
2022-11-22 10:17 ` Alexandre Mergnat
2022-11-16 12:33 ` [PATCH v5 10/10] Input: mtk-pmic-keys: add MT6357 support Alexandre Mergnat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ab0a069-355c-b3a7-450b-22e58d5f1ea8@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=chen.zhong@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fabien.parent@linaro.org \
--cc=flora.fu@mediatek.com \
--cc=fparent@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mkorpershoek@baylibre.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=tianping.fang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).