From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Quentin Schulz <quentin.schulz@theobroma-systems.com>,
Quentin Schulz <foss+kernel@0leil.net>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
heiko@sntech.de, dmitry.torokhov@gmail.com,
klaus.goger@theobroma-systems.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard
Date: Fri, 23 Sep 2022 12:28:50 +0200 [thread overview]
Message-ID: <3b0c9c24-ecb5-04df-67de-62f584fabdfd@linaro.org> (raw)
In-Reply-To: <f72271d7-9f42-45e9-01a4-590bd20250ab@theobroma-systems.com>
On 23/09/2022 11:55, Quentin Schulz wrote:
>>> +
>>> + leds {
>>> + compatible = "gpio-leds";
>>
>> This belongs to DTSI.
>>
>
> It is in the DTSI :)
Ah, right...
>
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&module_led_pin>;
>>> + status = "okay";
>>
>> No need.
>>
>>> +
>>> + module_led: led-0 {
>>
>> Why DTSI - which in logic comes first - starts with 1 and this is 0?\
>>
>
> The first diff in this patch is for the DTS, this is now the DTSI. So it
> does have led-0 in the DTSI and led-1 in the DTS which I think is what
> you're requesting here? Is this a correct assumption?
Yep.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-23 10:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220922101211.3215888-1-foss+kernel@0leil.net>
2022-09-22 10:12 ` [PATCH 1/3] Input: add `SW_BOOT_ALT` Quentin Schulz
2022-09-22 17:20 ` Jeff LaBundy
2022-09-23 8:25 ` Quentin Schulz
2022-09-23 17:19 ` Jeff LaBundy
2022-09-23 17:24 ` Dmitry Torokhov
2022-09-26 9:37 ` Quentin Schulz
2022-09-27 1:56 ` Jeff LaBundy
2022-09-27 8:51 ` Quentin Schulz
2022-09-27 12:57 ` Robin Murphy
2022-09-22 10:12 ` [PATCH 2/3] arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard Quentin Schulz
2022-09-22 11:56 ` Quentin Schulz
2022-09-22 12:45 ` Krzysztof Kozlowski
2022-09-23 9:55 ` Quentin Schulz
2022-09-23 10:28 ` Krzysztof Kozlowski [this message]
2022-09-22 10:12 ` [PATCH 3/3] dt-bindings: arm: rockchip: add Theobroma Systems PX30-µQ7 (Ringneck) with Haikou Quentin Schulz
2022-09-22 12:40 ` Krzysztof Kozlowski
2022-09-22 12:41 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b0c9c24-ecb5-04df-67de-62f584fabdfd@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=foss+kernel@0leil.net \
--cc=heiko@sntech.de \
--cc=klaus.goger@theobroma-systems.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=quentin.schulz@theobroma-systems.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).