From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH] platform/x86: silead_dmi: Add touchscreen platform data for the Chuwi Surbook Mini tablet. Date: Sat, 3 Aug 2019 16:16:39 +0200 Message-ID: <3c8b8c8c-0674-9fb2-a28e-ceaea58fcece@redhat.com> References: <20190803141222.9460-1-ohaibuzzle@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190803141222.9460-1-ohaibuzzle@gmail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Giang Le Cc: dvhart@infradead.org, andy@infradead.org, linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-input@vger.kernel.org Hi, On 03-08-19 16:12, Giang Le wrote: Hmm, could have used a somewhat more verbose commit message above the Signed-off-by line, but I guess there is not that much to write about this patch. > Signed-off-by: Giang Le Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/touchscreen_dmi.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c > index 4370e4add83a..72535b0268eb 100644 > --- a/drivers/platform/x86/touchscreen_dmi.c > +++ b/drivers/platform/x86/touchscreen_dmi.c > @@ -136,6 +136,22 @@ static const struct ts_dmi_data chuwi_vi10_data = { > .properties = chuwi_vi10_props, > }; > > +static const struct property_entry chuwi_surbook_mini_props[] = { > + PROPERTY_ENTRY_U32("touchscreen-min-x", 88), > + PROPERTY_ENTRY_U32("touchscreen-min-y", 13), > + PROPERTY_ENTRY_U32("touchscreen-size-x", 2040), > + PROPERTY_ENTRY_U32("touchscreen-size-y", 1524), > + PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-chuwi-surbook-mini.fw"), > + PROPERTY_ENTRY_U32("silead,max-fingers", 10), > + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"), > + { } > +}; > + > +static const struct ts_dmi_data chuwi_surbook_mini_data = { > + .acpi_name = "MSSL1680:00", > + .properties = chuwi_surbook_mini_props, > +}; > + > static const struct property_entry connect_tablet9_props[] = { > PROPERTY_ENTRY_U32("touchscreen-min-x", 9), > PROPERTY_ENTRY_U32("touchscreen-min-y", 10), > @@ -646,6 +662,14 @@ static const struct dmi_system_id touchscreen_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "S165"), > }, > }, > + { > + /* Chuwi Surbook Mini (CWI540) */ > + .driver_data = (void *)&chuwi_surbook_mini_data, > + .matches = { > + DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"), > + DMI_MATCH(DMI_PRODUCT_NAME, "C3W6_AP108_4G"), > + }, > + }, > { > /* Connect Tablet 9 */ > .driver_data = (void *)&connect_tablet9_data, >