From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Oliver Neukum <oneukum@suse.com>, Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Terry.Junge@plantronics.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] HID: core: move Usage Page concatenation to Main item
Date: Wed, 27 Mar 2019 11:16:13 +0100 [thread overview]
Message-ID: <3ea28268d51c6d9befecf273e1295ba11f8d3b06.camel@suse.de> (raw)
In-Reply-To: <1553679302.14990.0.camel@suse.com>
[-- Attachment #1: Type: text/plain, Size: 702 bytes --]
Hi Oliver, thanks for the review!
On Wed, 2019-03-27 at 10:35 +0100, Oliver Neukum wrote:
> On Di, 2019-03-26 at 21:03 +0100, Nicolas Saenz Julienne wrote:
> > --- a/drivers/hid/hid-core.c
> > +++ b/drivers/hid/hid-core.c
> > @@ -218,13 +218,14 @@ static unsigned hid_lookup_collection(struct
> > hid_parser *parser, unsigned type)
> > * Add a usage to the temporary parser table.
> > */
> >
> > -static int hid_add_usage(struct hid_parser *parser, unsigned usage)
> > +static int hid_add_usage(struct hid_parser *parser, unsigned usage, __u8
> > size)
>
> No need to use the __u8 style inside the kernel. u8 will do.
Noted, fixed for v4.
>
> Regards
> Oliver
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-03-27 10:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 20:03 [PATCH v3] HID: core: move Usage Page concatenation to Main item Nicolas Saenz Julienne
2019-03-26 22:43 ` Junge, Terry
2019-03-27 10:15 ` Nicolas Saenz Julienne
2019-03-27 9:35 ` Oliver Neukum
2019-03-27 10:16 ` Nicolas Saenz Julienne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ea28268d51c6d9befecf273e1295ba11f8d3b06.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=Terry.Junge@plantronics.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).