From: "Shem Multinymous" <multinymous@gmail.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: ThinkPad input device IDs
Date: Wed, 8 Oct 2008 00:44:02 -0400 [thread overview]
Message-ID: <41840b750810072144g6e6becfby1c960eb24249869c@mail.gmail.com> (raw)
Hi Dmitry and Henrique,
We seem to have a bit of a mess in regard to input device
identification on ThinkPad-specific devices.
thinkpad-acpi does essentially the following (Henrique's commit
7f5d1cd62 from July 2007, after macro expansion):
tpacpi_inputdev->name = "ThinkPad Extra Buttons";
tpacpi_inputdev->phys = "thinkpad_acpi/input0";
tpacpi_inputdev->id.bustype = BUS_HOST;
tpacpi_inputdev->id.vendor = PCI_VENDOR_ID_IBM or PCI_VENDOR_ID_LENOVO;
tpacpi_inputdev->id.product = 0x5054 /* "TP" */;
tpacpi_inputdev->id.version = 0x4101;
But mainline hdaps uses a different convention (Dmitry's commit
d2fc60d692 from May 2008):
idev->name = "hdaps";
idev->phys = "isa1600/input0";
idev->id.bustype = BUS_ISA;
What's the rationale for the different bus and phys convention?
Also, where does the "isa1600" come from, and why BUS_ISA? As far as I
can tell, the input device polls the ThinkPad embedded controller via
the LPC bus interface of the chipset, so no ISA-like bus is involved.
More concretely:
The out-of-tree tp_smapi version of hdaps followed the thinkpad-acpi
convention so it now conflicts with mainline hdaps. Which should I
follow?
Shem
next reply other threads:[~2008-10-08 4:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 4:44 Shem Multinymous [this message]
2008-10-08 13:44 ` ThinkPad input device IDs Henrique de Moraes Holschuh
2008-10-08 18:12 ` Shem Multinymous
2008-10-08 23:56 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41840b750810072144g6e6becfby1c960eb24249869c@mail.gmail.com \
--to=multinymous@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).