Re: [PATCH v3 0/7] HID: asus: ASUS Zenbook Duo keyboard support

[Denis Benato <denis.benato@linux.dev>]

13 ott 2026 14:45:22 Rebecca Mara Müller <rebecca.mara@posteo.de>:

> On Tue, Oct 13, 2026 at 12:39:57PM +0200, Paolo Pisati wrote:
>> - Bind the Bluetooth IDs to HID_GROUP_GENERIC as well: over Bluetooth
>>   the touchpad is a second HID device with the same IDs, which hid-asus
>>   must leave to hid-multitouch (Sashiko).
>
> I re-tested v3 the same way as v2 on a UX8407AA: applied on top of
> base-commit 8099f9da59f1 (the resulting hid-asus.c matches the index
> line of 7/7), built unmodified as an out-of-tree module against a
> 7.0.11-based distribution kernel, with my userspace workaround stopped.
>
> - Docked (USB, 0b05:1cd7), module loaded with the keyboard attached and
>   then three dock cycles: the five keyboard interfaces bind to hid-asus,
>   the touchpad stays with hid-multitouch. Hotkeys, keyboard backlight,
>   volume/mute, mic mute, the screenshot key and Fn+F profile cycling
>   (balanced <-> performance) work. The delayed handshake re-send never
>   failed.
> - Bluetooth (0b05:1cd8): the keyboard device (generic group) binds to
>   hid-asus and the touchpad device (multitouch group) to hid-multitouch,
>   as intended by the v3 change. The same keys and the touchpad work.
>
> The screen brightness keys emit KEY_BRIGHTNESSDOWN/KEY_BRIGHTNESSUP when
> docked (checked with an evdev reader).
>
> My Tested-by from v2 holds for v3:
>

Hi all,

I'll re-send this mail as the other client formatted in html and the mailing list rejected the message. Apologies.

I'm currently on vacation so I will need to postpone reviewing this.

My greatest concern is with report size: every device needs its own and hardcoding it is not an option anymore because no device can be fully made happy (and working): xg mobile is 300, ally and new ROGs is 64, some have 32, some 16 and I think TP is 15.


I have yet to look at the patch that changes the report size but please make the report size variable reading it from the descriptor.

I will be beack the 18th October.

Best regards,
Denis



> Tested-by: Rebecca Mara Müller <rebecca.mara@posteo.de> # UX8407AA
>
> Thanks,
> Rebecca