From: Bastien Nocera <hadess@hadess.net>
To: Bryan Cain <bryancain3@gmail.com>, linux-input@vger.kernel.org
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH 1/1] HID: apple: Properly handle function keys on Keychron keyboards
Date: Fri, 06 May 2022 12:04:02 +0200 [thread overview]
Message-ID: <42bb6003dfa668b8829b8810bf97be2ba636857c.camel@hadess.net> (raw)
In-Reply-To: <20220505191221.36172-2-bryancain3@gmail.com>
On Thu, 2022-05-05 at 13:12 -0600, Bryan Cain wrote:
> + if (fnmode == 3) {
> + real_fnmode = (asc->quirks & APPLE_IS_KEYCHRON) ? 2 :
> 1;
> + } else {
> + real_fnmode = fnmode;
> + }
Wouldn't it be worth adding an enum for those values? (when the
configuration was added would have been a better time, but the second
best time to do it would be now ;)
next prev parent reply other threads:[~2022-05-06 10:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 19:12 [PATCH 0/1] HID: apple: Properly handle function keys on Keychron keyboards Bryan Cain
2022-05-05 19:12 ` [PATCH 1/1] " Bryan Cain
2022-05-06 9:43 ` Hans de Goede
2022-05-06 10:04 ` Bastien Nocera [this message]
2022-05-11 12:22 ` Jiri Kosina
2022-05-09 7:02 ` [PATCH 0/1] " José Expósito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42bb6003dfa668b8829b8810bf97be2ba636857c.camel@hadess.net \
--to=hadess@hadess.net \
--cc=benjamin.tissoires@redhat.com \
--cc=bryancain3@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).