From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BC2BEB64D9 for ; Thu, 15 Jun 2023 08:21:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244616AbjFOIVF (ORCPT ); Thu, 15 Jun 2023 04:21:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243483AbjFOIUo (ORCPT ); Thu, 15 Jun 2023 04:20:44 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D78FB26B8 for ; Thu, 15 Jun 2023 01:20:38 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4f7deee339dso1263007e87.0 for ; Thu, 15 Jun 2023 01:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686817237; x=1689409237; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=XMlsfgZLwaFXb+N9g5o4MdTI3z1v0qvGTnWntiOQBao=; b=oSIC7GffKE130lUEj4jrKtsYhelzdq6evUtya19QotqoHDz7V60LQyUuZIoYUCCDnN iCTeT9nwOGybArYq1Z9gt8KhsFMWgR6g4uyFQs7McQiY/Jvl/Kd/egY/9xFzeUzXeiYZ zHC+HHUos5I2qQr2t9EohcScyOtKhGFmxh1fUhYhYjXG+KkpQf5eaHTXKI7ahZLJVdz0 3kNTxX1KXjScNjjbIQzSraeTnNubYv+rEjUfkJyhIbLYM+2Bmlp1SfKOS8qsOgFyiRZc sxKO7ERFEYXzMldGFJjibwPKPN2416w8YKmyQdAtbmIpxkSUPtO740gP7tNUpyc8+o8V IpOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686817237; x=1689409237; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XMlsfgZLwaFXb+N9g5o4MdTI3z1v0qvGTnWntiOQBao=; b=W5FGUoQfywnA1OQIBQf5k3mcCN223amfq+5xPcBh2J2yN97y1ijoPhSA1rlBXCJow4 PsW7iYFDuZo9P2MhB5JoRpc7Sb9baZN6xHevVTHBZkeDhLlfXnEj7x2qrTOwa8dyMQC/ qZ9oK9xVBNxk59mVMgMcNbv8UN8cwwZ6WaIJzccqPtd5ay1uNQciMAcGvQII9ot0dGUN GLABqoU/stFyYmafzdm3tuNEL/J4Z1ClsYerp9bbAzgT4ymxi/E0otk2+7pf7hv9gN8f CKKPeLNm4JVsci6zoWu3nrCvGAT+3cHX0s0vcsNSBIeGAE56wJvzaTXnrLKWcKKY4P+H NXKQ== X-Gm-Message-State: AC+VfDyLNDv9Jb3HXDTgFYRYRerdP6TCrjmHXQjwQbgM6FfRvRri9i6V 4HYJbGFYukmHmK/lfjQsmDz8OA== X-Google-Smtp-Source: ACHHUZ5Nj3PdGNxt6Ji0K419vClPI6VhoNUfiucjsLCBZbaYz1Dm29Yg3AjeJRc312tcPz4Gf4guSQ== X-Received: by 2002:a19:770b:0:b0:4ec:a18e:f989 with SMTP id s11-20020a19770b000000b004eca18ef989mr7620536lfc.17.1686817237041; Thu, 15 Jun 2023 01:20:37 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:f60a:f5e3:7ae:6745? ([2a01:e0a:982:cbb0:f60a:f5e3:7ae:6745]) by smtp.gmail.com with ESMTPSA id t11-20020a7bc3cb000000b003f60eb72cf5sm19826825wmj.2.2023.06.15.01.20.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jun 2023 01:20:36 -0700 (PDT) Message-ID: <436d1428-9135-d207-7004-82713b015775@linaro.org> Date: Thu, 15 Jun 2023 10:20:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH RFC 4/4] input: touchscreen: add SPI support for Goodix Berlin Touchscreen IC Content-Language: en-US To: Jeff LaBundy Cc: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bastien Nocera , Hans de Goede , Henrik Rydberg , linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230606-topic-goodix-berlin-upstream-initial-v1-0-4a0741b8aefd@linaro.org> <20230606-topic-goodix-berlin-upstream-initial-v1-4-4a0741b8aefd@linaro.org> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 12/06/2023 19:07, Jeff LaBundy wrote: > Hi Neil, > > [...] > >>>> +static const struct input_id goodix_berlin_spi_input_id = { >>>> + .bustype = BUS_SPI, >>>> + .vendor = 0x0416, >>>> + .product = 0x1001, >>> >>> After having seen these in the I2C counterpart; consider defining them >>> in goodix_berlin.h. >> >> To be honest, I blindly copied it from goodix.c because the vendor >> driver puts random values here. >> >> input_dev->id.product = 0xDEAD; >> input_dev->id.vendor = 0xBEEF; >> >> So what should I set ? > > If there is no explicit guidance from the vendor, I would simply leave > these unassigned; in theory one would imagine that this controller would > have a different product ID than other models. I'll leave those unassigned for now, and perhaps we could find some firmware info value that could be used here. Neil > > [...] > > Kind regards, > Jeff LaBundy