Linux Input/HID development
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Gideon Heinz <gideonheinz02@gmail.com>
Cc: linux-input@vger.kernel.org, jkosina@suse.com, bentiss@kernel.org
Subject: Re: HID: logitech-hidpp: G920 FF init fails with -110 since "move FF initialization to .input_configured()"
Date: Thu, 05 Nov 2026 11:17:27 -0800	[thread overview]
Message-ID: <44267fc27bb527b5ea390ac53553dd7a@gmail.com> (raw)
In-Reply-To: <CAPb1+K0aFMox4-FTjODmOSN7iHDXfFGq-2jGfQyXcp+X_rNioA@mail.gmail.com>

Hi Gideon,

On Wed, Nov 04, 2026 at 09:32:04PM +0100, Gideon Heinz wrote:
> The init failure is fixed:
>
>   logitech-hidpp-device 0003:046D:C262.000B: Force feedback support
>   loaded (firmware release 4).
>   logitech-hidpp-device 0003:046D:C262.000B: HID++ 4.2 device connected.
>
> No -110 anymore, and fftest lists all effect types with uploads OK.
>
> One separate observation: when I play the constant effect in fftest,
> dmesg shows "Force feedback command queue contains 20 commands, causing
> substantial delays!" followed by "Failed to send command to device!".
> This doesn't happen on stock Arch 7.2.11 (no patch, old init order).
> I haven't determined whether it's related to the patch, to other 7.3
> changes, or specific to the CachyOS kernel build. I can capture usbmon
> of it if that helps.

Thank you for testing!

Yes, a usbmon capture along with matching dmesg output would be very
helpful. Also, when you played the constant effect, did the wheel
actually produce any force (perhaps after a delay), or was force feedback
completely unresponsive?

Note that hid-logitech-hidpp queues all FF commands (gain, effect
uploads, playback, erase-on-close, and sysfs "range" writes) onto an
asynchronous workqueue, so fftest prints "OK" on upload even if the
worker thread is stalled. If anything queues a command while the input
device is closed and the interrupt IN URB is not running (for instance
cleanup commands from closing an earlier fftest run within ~15 seconds,
or a udev rule writing to the "range" sysfs attribute after probe), the
worker gets stuck waiting 3 x 5s for a reply and later commands pile up
behind it. On the other hand, if commands are timing out while fftest is
the first user and keeping the device open, the inverted init order
(hidpp_connect_event() now running after g920_get_config()) or another
7.3 change may be upsetting the device or endpoint.

If you can start usbmon before loading the patched module (or plugging
the wheel in), wait ~20 seconds after probe settles, and then run fftest
once to trigger the constant effect before exiting, that should tell us
immediately which case it is.

Thanks.

-- 
Dmitry

  parent reply	other threads:[~2026-11-05 19:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 13:23 HID: logitech-hidpp: G920 FF init fails with -110 since "move FF initialization to .input_configured()" Gideon Heinz
2026-11-02 17:37 ` Dmitry Torokhov
     [not found]   ` <CAPb1+K0aFMox4-FTjODmOSN7iHDXfFGq-2jGfQyXcp+X_rNioA@mail.gmail.com>
2026-11-05 19:17     ` Dmitry Torokhov [this message]
     [not found]       ` <CAPb1+K3ca9HdcNxF+sckhL7-Ud11k5E+1vxmzsVK=h4srC3A4A@mail.gmail.com>
2026-11-09  6:10         ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44267fc27bb527b5ea390ac53553dd7a@gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=bentiss@kernel.org \
    --cc=gideonheinz02@gmail.com \
    --cc=jkosina@suse.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox