Re: [PATCH v6 16/19] HID: Add documentation for Lenovo Legion Go drivers

[Thomas Huth <thuth@redhat.com>]

  Hi!

On 12/03/2026 23.57, Derek John Clark wrote:
> On Wed, Mar 11, 2026 at 7:44 PM Akira Yokosawa <akiyks@gmail.com> wrote:
>> On Tue, 10 Mar 2026 07:29:34 +0000, Derek J. Clark wrote:
>>> Adds ABI documentation for the hid-lenovo-go-s and hid-lenovo-go
>>> drivers.
>>>
>>> Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>>> Signed-off-by: Derek J. Clark <derekjohn.clark@gmail.com>
>>> ---
>>> v3:
>>>    - Remove excess + from every line of patch.
>>> ---
>>>   .../ABI/testing/sysfs-driver-hid-lenovo-go    | 724 ++++++++++++++++++
>>>   .../ABI/testing/sysfs-driver-hid-lenovo-go-s  | 304 ++++++++
>>>   MAINTAINERS                                   |   2 +
>>>   3 files changed, 1030 insertions(+)
>>>   create mode 100644 Documentation/ABI/testing/sysfs-driver-hid-lenovo-go
>>>   create mode 100644 Documentation/ABI/testing/sysfs-driver-hid-lenovo-go-s
>>
>> This (commit 168c91839139 in next-20260311) causes a lot of new warnings
>> in "make htmldocs" such as:
>>
>> WARNING: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/os_mode is defined 2 times: /<...>/Documentation/ABI/testing/sysfs-driver-hid-lenovo-go:364; /<...>/Documentation/ABI/testing/sysfs-driver-hid-lenovo-go-s:234
>> WARNING: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/os_mode_index is defined 2 times: /<...>/Documentation/ABI/testing/sysfs-driver-hid-lenovo-go:373; /<...>/Documentation/ABI/testing/sysfs-driver-hid-lenovo-go-s:243
>> WARNING: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/touchpad/enabled is defined 2 times: /<...>/Documentation/ABI/testing/sysfs-driver-hid-lenovo-go:636; /<...>/Documentation/ABI/testing/sysfs-driver-hid-lenovo-go-s:252
>> [snip]
>>
>> Please fix.
>>
>> Thanks, Akira
> 
> Akira,
> 
> What would an appropriate solution look like? There are two separate
> drivers in this series that are modeled to provide a sysfs that is as
> close to each other as possible. Because of that, they do end up
> having identical attributes for many of the implemented features.

Just an idea, not sure whether it's feasible since I don't have the hardware 
for checking: Looking at drivers/hid/hid-lenovo-go-s.c and 
drivers/hid/hid-lenovo-go.c, it seems like they use different vendor IDs 
(USB_VENDOR_ID_QHE vs. USB_VENDOR_ID_LENOVO), so maybe the "<vendor-id>" 
part could be replaced with the real value in the entries to distinguish 
them in the kerneldocs?

  Thomas