From: Joe Perches <joe@perches.com>
To: Sandeep C S <sandeep.cs@samsung.com>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: gaudium.lee@samsung.com, ih0923.kim@samsung.com,
suhyun_.kim@samsung.com, jitender.s21@samsung.com,
junwan.cho@samsung.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [HID Patchsets for Samsung driver v4 2/6] HID: Samsung : Fix the checkpatch complain. Rewritten code using memcmp where applicable.
Date: Thu, 25 Jan 2024 13:54:04 -0800 [thread overview]
Message-ID: <443a7a529f6987eb53b8b399c0cf9375e05e993c.camel@perches.com> (raw)
In-Reply-To: <20240125043630.4031634-3-sandeep.cs@samsung.com>
On Thu, 2024-01-25 at 10:06 +0530, Sandeep C S wrote:
> Resolved warnings found by checkpatch.pl script.
[]
> diff --git a/drivers/hid/hid-samsung.c b/drivers/hid/hid-samsung.c
> @@ -107,17 +99,39 @@ static int samsung_kbd_mouse_input_mapping(struct hid_device *hdev,
>
> switch (usage->hid & HID_USAGE) {
> /* report 2 */
> - case 0x183: samsung_kbd_mouse_map_key_clear(KEY_MEDIA); break;
> - case 0x195: samsung_kbd_mouse_map_key_clear(KEY_EMAIL); break;
> - case 0x196: samsung_kbd_mouse_map_key_clear(KEY_CALC); break;
> - case 0x197: samsung_kbd_mouse_map_key_clear(KEY_COMPUTER); break;
> - case 0x22b: samsung_kbd_mouse_map_key_clear(KEY_SEARCH); break;
> - case 0x22c: samsung_kbd_mouse_map_key_clear(KEY_WWW); break;
> - case 0x22d: samsung_kbd_mouse_map_key_clear(KEY_BACK); break;
> - case 0x22e: samsung_kbd_mouse_map_key_clear(KEY_FORWARD); break;
> - case 0x22f: samsung_kbd_mouse_map_key_clear(KEY_FAVORITES); break;
> - case 0x230: samsung_kbd_mouse_map_key_clear(KEY_REFRESH); break;
> - case 0x231: samsung_kbd_mouse_map_key_clear(KEY_STOP); break;
It's rather smaller code to remove the call duplication and use
a static const struct and for loop as suggested here:
https://lore.kernel.org/lkml/10aeef4ddd523b85ab34327bf384119d0d4b6567.camel@perches.com/
next prev parent reply other threads:[~2024-01-25 22:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240125043646epcas5p1d599fecff0fc37926295fc5260a80682@epcas5p1.samsung.com>
2024-01-25 4:36 ` [HID Patchsets for Samsung driver v4 0/6] Patchsets for Samsung driver Sandeep C S
2024-01-25 4:36 ` [HID Patchsets for Samsung driver v4 1/6] HID Samsung : Broaden device compatibility in samsung driver Sandeep C S
2024-01-25 4:36 ` [HID Patchsets for Samsung driver v4 2/6] HID: Samsung : Fix the checkpatch complain. Rewritten code using memcmp where applicable Sandeep C S
2024-01-25 21:54 ` Joe Perches [this message]
2024-01-25 4:36 ` [HID Patchsets for Samsung driver v4 3/6] HID: Samsung : Add Samsung wireless keyboard support Sandeep C S
2024-01-25 4:36 ` [HID Patchsets for Samsung driver v4 4/6] HID: Samsung : Add Samsung wireless gamepad support Sandeep C S
2024-01-25 4:36 ` [HID Patchsets for Samsung driver v4 5/6] HID: Samsung : Add Samsung wireless action mouse support Sandeep C S
2024-01-25 4:36 ` [HID Patchsets for Samsung driver v4 6/6] HID: Samsung : Add Samsung wireless bookcover and universal keyboard support Sandeep C S
2024-01-25 8:24 ` [HID Patchsets for Samsung driver v4 0/6] Patchsets for Samsung driver Jiri Kosina
2024-01-25 9:39 ` sandeep.cs
2024-01-25 9:41 ` sandeep.cs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443a7a529f6987eb53b8b399c0cf9375e05e993c.camel@perches.com \
--to=joe@perches.com \
--cc=benjamin.tissoires@redhat.com \
--cc=gaudium.lee@samsung.com \
--cc=ih0923.kim@samsung.com \
--cc=jikos@kernel.org \
--cc=jitender.s21@samsung.com \
--cc=junwan.cho@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeep.cs@samsung.com \
--cc=suhyun_.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox