From: Bastien Nocera <hadess@hadess.net>
To: linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, "Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Peter F . Patel-Schneider" <pfpschneider@gmail.com>,
"Filipe Laíns" <lains@riseup.net>
Subject: Re: [PATCH] HID: logitech-hidpp: Remove feature_type from hidpp_root_get_feature()
Date: Tue, 17 Sep 2024 20:38:36 +0200 [thread overview]
Message-ID: <44a94753410c3a96e6144f2ab19876f039d80707.camel@hadess.net> (raw)
In-Reply-To: <20240916115532.1806755-1-hadess@hadess.net>
On Mon, 2024-09-16 at 13:55 +0200, Bastien Nocera wrote:
> Nobody uses that variable after it gets assigned, so this saves us from
> having to declare it in the first place.
>
> Signed-off-by: Bastien Nocera <hadess@hadess.net>
I realised after sending the patch, as I was finishing up work on
enabling the Litra Beam light in user-space rather than the kernel[1],
that I didn't even compile-test this patch.
It's done now, and the patch compiles without warnings.
Enjoy Plumbers for those who celebrate.
Cheers
[1]: https://github.com/cvuchener/hidpp/pull/34
next prev parent reply other threads:[~2024-09-17 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 11:55 [PATCH] HID: logitech-hidpp: Remove feature_type from hidpp_root_get_feature() Bastien Nocera
2024-09-17 18:38 ` Bastien Nocera [this message]
2024-10-08 6:48 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44a94753410c3a96e6144f2ab19876f039d80707.camel@hadess.net \
--to=hadess@hadess.net \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=lains@riseup.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pfpschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).